From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yMODNhZi8WKa8QAAbAwnHQ (envelope-from ) for ; Mon, 08 Aug 2022 21:20:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sKijNRZi8WL2NgEAG6o9tA (envelope-from ) for ; Mon, 08 Aug 2022 21:20:54 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7614BF5C for ; Mon, 8 Aug 2022 21:20:54 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 232345F378; Mon, 8 Aug 2022 19:20:52 +0000 (UTC) Received: from mail.kisara.moe (119.ip-51-38-65.eu [51.38.65.119]) by mail.notmuchmail.org (Postfix) with ESMTPS id C00435E545 for ; Mon, 8 Aug 2022 19:20:49 +0000 (UTC) Received: from mk-desktop (unknown [141.98.252.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 9EB1AA0B51; Mon, 8 Aug 2022 21:20:48 +0200 (CEST) From: Mohsin Kaleem To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 6/9] test: Add test cases for new exclude option In-Reply-To: References: <87v8re66mg.fsf@tethera.net> <20220807145733.129867-1-mohkale@kisara.moe> <20220807145733.129867-6-mohkale@kisara.moe> Date: Mon, 08 Aug 2022 20:20:48 +0100 Message-ID: <87k07ir17z.fsf@kisara.moe> MIME-Version: 1.0 Message-ID-Hash: KET5WIYNFXQ6PWGJIOQR64FAFIRZKW7A X-Message-ID-Hash: KET5WIYNFXQ6PWGJIOQR64FAFIRZKW7A X-MailFrom: mohkale@kisara.moe X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659986454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=bdKet70A7gqSlVFpponas6aWnF3kx2f6amNOP0IAzVI=; b=Hw7HCt7qG/0HHyRDl8embusA/aNoR5HLdmTV0Imgr3HlnnkajtwgWBGejKkDdNXKf2M70n MdLcaKAUTHQlOI+TD2f49gnvW9FoJbzOfqa/rA5x4qJtqs2utBRxyr6muQYXLxPCQeRifd 0IURi6wLX3Kabb27ISGbend9M4Fz51KE+lrHEOPRptpeTRHl5nC/n4J0xp9G3V9GDP3rG0 2by2bTe6VDLsnmFkZBCedFdyNUCyWH4b8cGGjC1YJnPfYv9aMaCpVxY0XhrgAqngnl7m/G yxli3vACZDZIy0qn+yNYkTfK/GKVFzrW6RNd1lswl5FZyyxo10Tgd7ZkTzTDhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659986454; a=rsa-sha256; cv=none; b=KHbbm3LAe7+F2+ynOpvVBd31bURWE2NTr/aWV7seEUik0h2MOu7I4lNhwNNBELvFcw0fhy n9rZqiwSpDtknMrgFzZ5lj8a2Mfk/5vcft9ugO3LulgePGa4PAExz4Om2xZHlgJGwxadZN Sb+fNX756r/ymbILWRc9I8b6pCW80Kw6qbnVIt1to6m4aqjMIkQCztHqkYOtrfy6dEPeny 6wg/ZP1xLbyiNWEgd16oe6Hgslt+0TesO7y4JF8yyBvouubgZOyEm9krT/UXAuq8LIpSHp /LXLK3egVSKmTqJqVv/aphu4uinivdIO1mUUrLwi0wX72sjGWITVFbrWI3n0WA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kisara.moe (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 1.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kisara.moe (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A7614BF5C X-Spam-Score: 1.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: xaQRS+0pysGu Tomi Ollila writes: > It looks like tab width was not 8 when these (notmuch-search-toggle-exclude) > were added, accidentally indented w/ leading space, not tab ;/ > > (ditto for all other (notmuch-search-toggle-exclude), rest of the content > removed.) Ah, good job spotting this. My tab width defaults to 2 in sh-script files. I've fixed this now, but now sure what to do next. Should I generate a new patch series and send them all again, generate a new patch series and just send the modified patch, or is there some other convention for next steps? > Otherwise, in this large set of changes, I could not see anything alarming, > but I did not test (I even don't know how, as I don't have excludes...) An easy way to test would be to set some excluded tags :-). notmuch config set search.exclude_tags foo Then: 1. Go to your inbox in Emacs. 2. Tag some mail with foo. 3. Run `M-x notmuch-refresh-this-buffer` and the mail you tagged should no longer be shown. 4. Hit the i key and it will be shown again. 5. Hit i again and it will be hidden. 6. Hit i again to re-show it and go ahead and remove the foo tag 7. Run `M-x notmuch-refresh-this-buffer` or hit i as much as you like, the mail should now always be shown since its no longer excluded. -- Mohsin Kaleem