From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2OihOA1E62TrHAEAauVa8A:P1 (envelope-from ) for ; Sun, 27 Aug 2023 14:39:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2OihOA1E62TrHAEAauVa8A (envelope-from ) for ; Sun, 27 Aug 2023 14:39:42 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AAB855EFE5 for ; Sun, 27 Aug 2023 14:39:41 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=boula.in header.s=key1 header.b=4cbHkuyD; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=boula.in (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693139981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=FOwG4Vud+ImQQyazrc0MLQXme6unKakZcWGo/3Kkmk0=; b=T8byCTnkjePe6guM1zoBqhWMJqt8SvaVnvvpMXPSdNrd/AVZ3L0v+PyiRiSf+hzq3b4CyS 39LUrgyt/umu3wd3kNIT1ii5MwYUfYlWOwYKidCytCkupUbJMlvOJa7F12RAnKWz+xXumb 4cnP5EeeTUOfJkJikW/MRaW9h8HwTNAZYDxsMhmRJrU3Aba8g/tHj0oAiJJoYyTf0lOGTZ TKmRQZucDa5U3cwsThnPQ3KJJf/bOj5Gwvhwdo7kiFF3nRVoLmQ7REL82Ytj6LLT0lAwt4 P53XzM01TFzxxiwgLGgcxa5tDnbsYFkddmFfN7qRS8GGLGFA7STN46c0s1Ocwg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693139981; a=rsa-sha256; cv=none; b=DrbRTixu0s46mdPkm45cNuZupyOJBRTehYmn9VQQHDP7wxuQYZTb8+dMhRwUupc+4A0b1Y JXnXJLFKPRfVJeUE0K3+ZOexxsEj+keTvRMwS+SjlfH9iYKdsdxqee667/IeW2aarer8Bx xui85ZL104ehvkR1XrNobI8UfP9oWrmydNd4OiJx8/h9Q7r0VEDzaxIN69nBG+cyXHwrZn rBBBR95fquqcrl9RKtF/ZkqdzlqtPcAMm4RYTO0N2onFcisdlx+K/XUe3SkmFapicCwVcY DimaGm/q61f55r2JJjmeVFUbR8CW+/edk/tTMOnhtW5/9fbiGQxfNXqcx/vtEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=boula.in header.s=key1 header.b=4cbHkuyD; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=boula.in (policy=quarantine) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 45A745E54D; Sun, 27 Aug 2023 12:39:33 +0000 (UTC) Received: from out-245.mta1.migadu.com (out-245.mta1.migadu.com [IPv6:2001:41d0:203:375::f5]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1494C5DD59 for ; Sun, 27 Aug 2023 12:39:31 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boula.in; s=key1; t=1693139610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iUDgaGLPRPUkyHU+VKxTkLxdURtWa+iNrmVz6j+eYd4=; b=4cbHkuyDBkH907TvYZvhx7pX8zmHy+4wTWs0Q/Z0V2TgbmpC9skMQg/h1X2R9bsImnNySH uRMNCTa1rq0X1plJS1CUHrkFczA4uLO1d/M60ZhzYzUTnwtGzvg8VFcJL/0s/APsS4+ypZ LMxEZ7dOrNJrZp7CqVGgMDt/Rbwd7s/KN/bLm0iDqQaOHdXZPuykIdSNAyu2QVgBL92Xy7 zSlCZf/di9lqHrrNLpuawdoP4Zh3DH3haP0o1gqfP7IrCQmOgxf3PWJsJVvbob7hC9K5Ep S1uL/+Z0Ch8/OpeZISzNMXsHKmQm0Ou9puKPAZghaExbSAJCefQLV/xO66Z6UQ== From: Kevin Boulain To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] lib: thread-safe s-expression query parser In-Reply-To: <87fs5fg40h.fsf@tethera.net> References: <20230403203146.39749-1-kevin@boula.in> <20230403203146.39749-2-kevin@boula.in> <87fs5fg40h.fsf@tethera.net> Date: Sun, 27 Aug 2023 14:33:16 +0200 Message-ID: <87jztg3bsj.fsf@boula.in> MIME-Version: 1.0 Message-ID-Hash: 6K4HDAUXTPSXOUPVNGX3KPUAUHVCP67H X-Message-ID-Hash: 6K4HDAUXTPSXOUPVNGX3KPUAUHVCP67H X-MailFrom: kevin@boula.in X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Spam: Yes X-Migadu-Spam-Score: 6.00 X-Spam-Score: 6.00 X-Migadu-Queue-Id: AAB855EFE5 X-Migadu-Spam: Yes X-Migadu-Scanner: mx1.migadu.com X-TUID: seRaOiE6soN2 On 2023-07-22 at 16:06 -03, David Bremner wrote: > My first thought was that this should be static, but maybe it doesn't > matter in C++; I see the other inline functions in that file are not > declared static. True, I should have marked this function static. I did the same for the others. > I stumbled over the logic this code. I would prefer not to use assert > for this. In a few other places we call INTERNAL_ERROR from a default: > case. Thanks for the pointer, I removed the assert.