unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Kevin Boulain <kevin@boula.in>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] lib: thread-safe s-expression query parser
Date: Sun, 27 Aug 2023 14:33:16 +0200	[thread overview]
Message-ID: <87jztg3bsj.fsf@boula.in> (raw)
In-Reply-To: <87fs5fg40h.fsf@tethera.net>

On 2023-07-22 at 16:06 -03, David Bremner <david@tethera.net> wrote:
> My first thought was that this should be static, but maybe it doesn't
> matter in C++; I see the other inline functions in that file are not
> declared static.

True, I should have marked this function static. I did the same for the
others.

> I stumbled over the logic this code. I would prefer not to use assert
> for this. In a few other places we call INTERNAL_ERROR from a default:
> case.

Thanks for the pointer, I removed the assert.

  parent reply	other threads:[~2023-08-27 12:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 20:31 [PATCH 1/2] test: showcase thread-unsafe s-expression query parser Kevin Boulain
2023-04-03 20:31 ` [PATCH 2/2] lib: thread-safe " Kevin Boulain
2023-07-22 19:06   ` David Bremner
2023-08-27 12:31     ` [PATCH v2 1/2] test: showcase thread-unsafe " Kevin Boulain
2023-09-19 10:30       ` David Bremner
2023-08-27 12:31     ` [PATCH v2 2/2] lib: thread-safe " Kevin Boulain
2024-07-25 10:23       ` David Bremner
2023-08-27 12:33     ` Kevin Boulain [this message]
2023-07-22 18:48 ` [PATCH 1/2] test: showcase thread-unsafe " David Bremner
2023-07-23 13:23   ` Michael J Gruber
2023-07-23 14:03     ` David Bremner
2023-08-06 10:05   ` Kevin Boulain
2023-08-06 12:01     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jztg3bsj.fsf@boula.in \
    --to=kevin@boula.in \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).