From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6BcUCp+T3Wbf9wAA62LTzQ:P1 (envelope-from ) for ; Sun, 08 Sep 2024 12:07:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6BcUCp+T3Wbf9wAA62LTzQ (envelope-from ) for ; Sun, 08 Sep 2024 14:07:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=X+P8pR3M; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725797278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XX3weT7DX6ssvWIbL0VWNwfwX7ckMJr+yo7x7uexMTs=; b=h0Y2ALik/pVbqGaWDzgLMAhiQ7UaHZudvelJBJe9fO3yxhOKuxWW3rLZPSWxsMjUKz/td1 yAtKC2insTkeC61VqrvXzA2tiuoQ33gM95+Tk8Qcfgt4YmcO+X7Yfa89JcQqVWqu4ye/MS XwbzVaLaBJmyfHXEh9C+39Kvr1SaSGfC+kff0auZW/OWdlJvmDfUsaycgNGKK5+9OzQ2py VNXtuvlhiuz+/SfMrFSiyT3NS5ZbfPWRdaMo+nMqODrbztKyNu/v7T8w2G8BSmIkNMZ8ce 3kfpE2D/Ji02hVDQoBp/JRqw+hNCw+9si0yxpWFgIarybpEZMFNjOPdFSWKHJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=X+P8pR3M; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725797278; a=rsa-sha256; cv=none; b=nGv7qKKIkjxSKjjjp5QIYVJ01a4NUC7UizyQ7ycWFccga+kZZOWhM8bhb3LZ1O4A8bQXjz X5OOorR2v2S1TvpxiiJ3Y6axBo6fwopfqQPltWtpo+uRMt7UiHoOUt4JFlJaJUq0tISp97 Ywlz0h5EAyZ4QBfIV3O9qmcK5ID8Soa+SHoMwdAW37PeHIRigE4roV9x5FDHuP7eKJWSR9 tcvhQADkZUX1/LjaC3sZGJnf6+F2C2NJoATBfOp19OY4O3dn+gPWvNB1QMeNICyRjLJr1k YGllPtij6OHa1O1psReTO+GY4fSryNKthQk6i3TaYWxLU/c3oCxN65c35X3POw== Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DEB923781A for ; Sun, 08 Sep 2024 14:07:58 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 822495E295; Sun, 8 Sep 2024 12:07:56 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id BB7EE5E292 for ; Sun, 8 Sep 2024 12:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tethera.net; i=@tethera.net; q=dns/txt; s=2024; t=1725797272; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=yVnKnHlMWfD64a8n2k+lYGf2h64McoVu41ugfhkHH+Q=; b=X+P8pR3MDijoMGkmk0iaQ+9GNZMdQqb9W4Z2UO7qqIuRsI14znOQv9pKCOhHpPsY7rhZi lXwpBZO4d/s7znX2+wc2C0nRtrdFkQagcCDFVZGNlLO2nXRSdJFue4M6LEimNswsJ+aUbdK vYK+NEB9lTlgFESw8u2flrUWYnC10GUWYgVL31GQFqXETyU2aZmu6OmqYefiY6g40iJT2dZ lCAgmLpsd7TRQYKqRjavP+GkQ9ZpiaEi+fqk9TInukzvijYeOCFdwJKtKz24sE/JRrI5hrn 5Z+NxxDGXCtsUc6h3fxBXzS5ow1qeex448clyy0uJ4V7RHRJ9YC92Seh3tpg== Received: from tethera.net (fctnnbsc51w-159-2-211-58.dhcp-dynamic.fibreop.nb.bellaliant.net [159.2.211.58]) by phubs.tethera.net (Postfix) with ESMTPS id 38502180181 for ; Sun, 8 Sep 2024 09:07:52 -0300 (ADT) Received: (nullmailer pid 294565 invoked by uid 1000); Sun, 08 Sep 2024 12:07:51 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: git-remote-notmuch v2 In-Reply-To: <20240908113937.286108-1-david@tethera.net> References: <20240908113937.286108-1-david@tethera.net> Date: Sun, 08 Sep 2024 09:07:51 -0300 Message-ID: <87jzfm4aco.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: IZSW2OROLZJEIRO77HCBB7BJQZ3LSMYU X-Message-ID-Hash: IZSW2OROLZJEIRO77HCBB7BJQZ3LSMYU X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.65 X-Migadu-Queue-Id: DEB923781A X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.65 X-TUID: PFq6oV/Z530i Apologies for the lack of subject. Still caffeine deficient this morning... David Bremner writes: > 7) This code makes heavier use of GLib than most notmuch code. In > particular there is extensive use of g_auto macros for memory > management. These could be replaced with more use of talloc, but that > would require a few more low level utility routines to be written. The other thing it makes me think is that GLib is arguably badly re-inventing C++, so that's something to ponder. I don't know if argues for just using C++, or for going the extra mile and using talloc. > 8) Performance has been optimized for the case of few changes to the > database since last git-push (analogous notmuch restore) 9) I replaced the shelling out to "git var" with interrogating the notmuch configuration database. The behaviour is slightly different, in particular GIT_COMMITTER_* environment variables are currently ignored. Obeying those could be added fairly simply, I think. There are probably other subtlties to how git constructs GIT_COMMITTER_IDENT; I'm not sure if those are important. 10) I observed there are still a few relics of the "git-remote-nm" name in the code. 11) I think this should eventually save and restore configuration information and properties like dump / restore do. I don't see any conceptual barrier to doing so, just more code.