unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: git-remote-notmuch v2
Date: Sun, 08 Sep 2024 09:07:51 -0300	[thread overview]
Message-ID: <87jzfm4aco.fsf@tethera.net> (raw)
In-Reply-To: <20240908113937.286108-1-david@tethera.net>


Apologies for the lack of subject. Still caffeine deficient this
morning...

David Bremner <david@tethera.net> writes:

> 7) This code makes heavier use of GLib than most notmuch code.  In
> particular there is extensive use of g_auto macros for memory
> management.  These could be replaced with more use of talloc, but that
> would require a few more low level utility routines to be written.

The other thing it makes me think is that GLib is arguably badly
re-inventing C++, so that's something to ponder. I don't know if argues
for just using C++, or for going the extra mile and using talloc.

> 8) Performance has been optimized for the case of few changes to the
> database since last git-push (analogous notmuch restore)

9) I replaced the shelling out to "git var" with interrogating the
notmuch configuration database. The behaviour is slightly different, in
particular GIT_COMMITTER_* environment variables are currently
ignored. Obeying those could be added fairly simply, I think. There are
probably other subtlties to how git constructs GIT_COMMITTER_IDENT; I'm
not sure if those are important.

10) I observed there are still a few relics of the "git-remote-nm" name
in the code.

11) I think this should eventually save and restore configuration
    information and properties like dump / restore do. I don't see any
    conceptual barrier to doing so, just more code.


      parent reply	other threads:[~2024-09-08 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08 11:27 David Bremner
2024-09-08 11:27 ` [PATCH v2 1/4] util: refactor sync_dir and mkdir_recursive David Bremner
2024-09-08 11:27 ` [PATCH v2 2/4] cli: start remote helper for git David Bremner
2024-10-03 11:22   ` David Bremner
2024-10-03 11:26     ` David Bremner
2024-09-08 11:27 ` [PATCH v2 3/4] cli/git-remote: add import command David Bremner
2024-09-08 11:27 ` [PATCH v2 4/4] cli/git-remote: add export command David Bremner
2024-09-08 12:07 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzfm4aco.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).