unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: Carl Worth <cworth@cworth.org>, Notmuch list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] RFC: User-Agent header
Date: Wed, 14 Apr 2010 09:44:16 +0200	[thread overview]
Message-ID: <87iq7ubhrj.fsf@SSpaeth.de> (raw)
In-Reply-To: <87bpdnl02k.fsf@yoom.home.cworth.org>

On 2010-04-13, Carl Worth wrote:
> > OK, final post from me on this issue.
> No, wait! I want more from you. :-)

Sigh, they always want more :-)
 
> Would you care to put together a solution that does this from within
> notmuch*.el ? I really want things usable by default without people
> having to hack up their .emacs files.

See the "sister mail" to this thread, in which I simply added the whole
shebang to notmuch.el (not using a lambda function). Is that what you
had in mind. Mind you, my elisp knowledge borders close to 0, so I would
be surprised if I did not botch up things. However, I have tested the
patch, and the User-Agent header got inserted.
 
> Of course, we could also easily add a variable to make this not happen,
> (but that can be added in a follow-on patch by anyone).

Some don't want it, but it cannot be disabled in this patch, so that
would indeed need to be a followup patch.

This gets now inserted (message mode automatically wrapped the header
like this):
User-Agent: notmuch version 0.1-107-g553feae (Emacs
	23.1.1/x86_64-pc-linux-gnu)

Is that an acceptable format? I would have preferred to not include the
"version" string, but notmuch --version spits that out, and it was just
easier to leave it in. 

Is that "version" really needed, BTW? Why can't notmuch --version not just say:
notmuch 0.1-107-g553feae

Sebastian

  parent reply	other threads:[~2010-04-14  7:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08  8:26 RFC: User-Agent header Sebastian Spaeth
2010-04-08 15:12 ` Dirk Hohndel
2010-04-10  2:55   ` Carl Worth
2010-04-10  4:43     ` Dirk Hohndel
2010-04-10 13:16     ` Jameson Rollins
2010-04-10 14:00     ` Sebastian Spaeth
2010-04-10 14:45       ` Dirk Hohndel
2010-04-10 14:02   ` Xavier Maillard
2010-04-11 22:12 ` Sebastian Spaeth
2010-04-12  5:45   ` David Edmondson
2010-04-12  8:30   ` [PATCH] " Sebastian Spaeth
2010-04-13 17:44     ` Carl Worth
2010-04-13 22:55       ` Xavier Maillard
2010-04-14  7:38       ` [PATCH 13/13] notmuch.el: Add a function to insert a notmuch user-agent header Sebastian Spaeth
2010-04-14  7:44         ` David Edmondson
2010-04-14  9:52           ` Sebastian Spaeth
2010-04-14  7:44       ` Sebastian Spaeth [this message]
2010-04-15 19:52         ` [PATCH] RFC: User-Agent header Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iq7ubhrj.fsf@SSpaeth.de \
    --to=sebastian@sspaeth.de \
    --cc=cworth@cworth.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).