From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4D866429E25 for ; Fri, 3 Jun 2011 13:21:44 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4GzzROLEwXLh for ; Fri, 3 Jun 2011 13:21:43 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E5B08431FB6 for ; Fri, 3 Jun 2011 13:21:42 -0700 (PDT) Received: by bwg12 with SMTP id 12so2235026bwg.26 for ; Fri, 03 Jun 2011 13:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=iF0NXSwJuOa5sdbVHBehW3+jhit6R0dJghVLfkbctwQ=; b=P65NDbNFIEejt788NfH1zcEP1ogNULbUE9jg4ibGMPneFRzacS5n6UMrsSAmky6U4T dAoXtk3GbvxwLo4P/hdxnjLloye7481KXgFFYRSY+zeeeqiOwp7mKnQDMaVaFwXYBNi1 ikifO4PXrrvzgYaauFJ5LZA5euF8Rj19UEkck= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; b=Oc2X8cOjN32QbQ9i5kwj7gyJ7kASXxxuWJjrhbnZBpYOVjpkhiwe0q22zyA8Kx4VUS 47Nkr155cLPrKEj0T6EUcSVKhZFkM9QMynBoqmS0loE5uOKLzWCkX3w6RHdPoV1AuBHw /KVW3H7jzv49fs+5T9duSy+Vplc0/Auk+1Mnw= Received: by 10.204.38.194 with SMTP id c2mr2219135bke.90.1307132501388; Fri, 03 Jun 2011 13:21:41 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id k10sm1498019bkq.22.2011.06.03.13.21.39 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Jun 2011 13:21:39 -0700 (PDT) From: Dmitry Kurochkin To: Carl Worth , Notmuch Mail Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. In-Reply-To: <87oc2ellzn.fsf@yoom.home.cworth.org> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> <1306619520-25730-9-git-send-email-jrollins@finestructure.net> <1306619520-25730-10-git-send-email-jrollins@finestructure.net> <1306619520-25730-11-git-send-email-jrollins@finestructure.net> <1306619520-25730-12-git-send-email-jrollins@finestructure.net> <1306619520-25730-13-git-send-email-jrollins@finestructure.net> <1306619520-25730-14-git-send-email-jrollins@finestructure.net> <1306619520-25730-15-git-send-email-jrollins@finestructure.net> <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com> <87oc2ellzn.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.5-208-g109ec1a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 04 Jun 2011 00:22:04 +0400 Message-ID: <87ipsmpswj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 20:21:44 -0000 On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin wrote: > > Well, it says that changes are in notmuch 0.5. So "old" and "previous" > > refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5. > > Sure, but I happen to ahve already forgotten the details of how the > variable could be configured in 0.4 and in 0.5. More importantly, anyone > in the future reading the commit log is much more likely not to > remember. > > > Any configuration when `notmuch-fcc-dirs' is a list. That variable has > > a nice documentation. > > Again, I'd like our commit messages to be self-contained. They are much > more useful if the describe the change being made without assuming to > much outside knowledge. > > > > It would be easier to understand the code if there were a corresponding > > > test case for it. > ... > > I do not think we need a test for this fix. What we need are tests for > > FCC functionality when notmuch-fcc-dirs is a list. > > Yes! > > > Old configuration format was changed in 0.5 in an incompatible way. > > There is a check for the unsupported old-style configuration. But the > > check is broken and results in an error when running with a valid > > new-style configuration. > > This is actually what I meant by "corresponding test case". If the bug > here is that a "new-style configuration" doesn't work , (and I still > don't like that wording---don't say "new style"---explain what it > actually *is*), then yes, we need a test case showing that bug. > > > I am not sure what you expect from the commit message here. IMO it is > > enough for this small bugfix and those who interested can always refer > > to documentation for details. > > The commit message should provide a self-contained description of the > change. It should be along the lines of: > > When fcc-dirs is set to > notmuch was > incorecctly detecting this as the > and generating an error > message. Fix the test so that this configuration now works. > > Where the above should be replaced with actual descriptions, > not relative pointers to information like "old style" or "new style". > > Does that make sense? > "notmuch was incorecctly detecting this as the ..." is not right. It is a wrong-type-argument lisp error (evaluating (length '(a . b))). How about: Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when `notmuch-fcc-dirs' is set to a list. The error was in the `notmuch-fcc-dirs' format check which was changed in an incompatible way from 0.4 to 0.5. Regards, Dmitry > -Carl Non-text part: application/pgp-signature