From: Carl Worth <cworth@cworth.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/2] Make `notmuch-show-clean-address' parsing-error-proof.
Date: Fri, 03 Jun 2011 14:10:54 -0700 [thread overview]
Message-ID: <87ipsmlixt.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1305208586-24689-1-git-send-email-dmitry.kurochkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On Thu, 12 May 2011 17:56:25 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Mail-header-parse-address may fail for an invalid address.
> Before the change, this would result in empty notmuch-show buffer
> with an error message like: Scan error: "Unbalanced parentheses".
> The patch wraps the function in condition-case and returns
> unchanged address in case of error.
Thanks for the patch, Dmitry. I've just pushed this.
And thanks as well for the test case. I actually pushed the test-case
commit before the bug-fix commit. I like to do things in that order so
that I can:
1. Apply the new test case
2. Run "make test" and see the failure
3. Apply the bug fix
4. Run "make test" and see the test pass
With a sequence like that, it's very easy for me to feel very
comfortable committing the code.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2011-06-03 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 13:56 [PATCH 1/2] Make `notmuch-show-clean-address' parsing-error-proof Dmitry Kurochkin
2011-05-12 13:56 ` [PATCH 2/2] test: add "notmuch-show for message with invalid From" test Dmitry Kurochkin
2011-06-03 21:10 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipsmlixt.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).