From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH] libnotmuch: build symbols list without relying on gcc -aux-info.
Date: Tue, 28 Jun 2011 12:04:39 -0700 [thread overview]
Message-ID: <87iprpaibc.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1309142545-30590-1-git-send-email-david@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Sun, 26 Jun 2011 23:42:25 -0300, david@tethera.net wrote:
> Here is another way of doing this, probably better unless you are
> very attached to the idea of declaring the API in the header file.
Thanks for both of these, David. I've gone ahead and pushed the first,
(generating the symbol list with sed and notmuch.h).
I assume by "better" you mean that this one is less fragile to issues
like the precise formatting of our notmuch.h header file.
Meanwhile, though, our API *is* declared in the header file, (that's
what the header file exists for), so I do prefer to base our symbol list
on it.
In fact, the ideal would probably be to take the objdump method and use
it in the test suite to verify that its output matches the contents of
notmuch.sym generated from the header file.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-06-28 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 1:08 [PATCH] libnotmuch: build symbols list without relying on gcc -aux-info david
2011-06-27 2:42 ` david
2011-06-28 19:04 ` Carl Worth [this message]
2011-06-28 19:45 ` David Bremner
2011-11-29 6:51 ` New test for exported symbols David Bremner
2011-11-29 6:51 ` [PATCH 1/2] test/symbol-hiding: add some whitespace between tests David Bremner
2011-11-29 6:51 ` [PATCH 2/2] test/symbol-hiding: compare exported symbols with existing one David Bremner
2011-12-08 0:59 ` New test for exported symbols David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iprpaibc.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=bremner@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).