From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 439E2429E5B for ; Tue, 28 Jun 2011 20:14:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IfhR43hfHWWU for ; Tue, 28 Jun 2011 20:14:15 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id C253A429E55 for ; Tue, 28 Jun 2011 20:14:15 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 87B5D29A51E; Tue, 28 Jun 2011 20:14:14 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 75BEB2541A8; Tue, 28 Jun 2011 20:14:14 -0700 (PDT) From: Carl Worth To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] Add part filename and content-id in notmuch show output if available. In-Reply-To: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Tue, 28 Jun 2011 20:14:08 -0700 Message-ID: <87iprp72in.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 03:14:16 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, 29 May 2011 02:03:47 +0400, Dmitry Kurochkin wrote: > Also, the patch adds Content-id to text output format of notmuch > show. I don't think I've raised this point before, but I've been tempted to setup a git hook that rejects any commits with a paragraph beginning with the word "also" or the word "additionally". These words are clues to me that the commit is doing multiple independent things and should really be split up. > The patch makes notmuch show always output filename if available, > independent of Content-Disposition. Both JSON and text output > formats are changed. The commit message claims to change both JSON and text output, (and the patch bears that out). But the test suite only gets changes to text output. This suggests to me that the test suite needs an additional test here (for a "Content-Disposition: inline" attachment with a filename). What can I say, I must be feeling soft today, because in spite of both of those issues I've just pushed these two commits, (I did augment the commit message of the second commit to be more than a single line=E2=80=94I= know that I've discussed that issue before). Thanks, Dmitry, for the improvements. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4KmIAACgkQ6JDdNq8qSWjm0gCfdxQ/xyL3eA1eMhHDLooglEha x1IAniiWNWvrNUy1R5nh9G5G6hpP0lWE =fW5D -----END PGP SIGNATURE----- --=-=-=--