From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B226C431FD0 for ; Wed, 9 Nov 2011 10:51:02 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.1 X-Spam-Level: X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uhLNE7XGZ6yN for ; Wed, 9 Nov 2011 10:51:02 -0800 (PST) Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222]) by olra.theworths.org (Postfix) with ESMTP id 03F3E431FB6 for ; Wed, 9 Nov 2011 10:51:01 -0800 (PST) Received: from odin.local (4va54-1-87-88-247-156.dsl.sta.abo.bbox.fr [87.88.247.156]) by ks3536.kimsufi.com (Postfix) with ESMTPSA id A7FA36A0026; Wed, 9 Nov 2011 19:50:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net; s=key-schnouki; t=1320864659; bh=zNTWUuYd3mm5WkDD7NlPEHwBQpfNxtq1w2zaz+eIzm0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MPYMZQNzHN7cayKu8U51T8kWCSV+Tf6gc7WWB77fgllYnLMHJbEuZJV5nCpUD3Kfr dcbe3QuYCLQbgySZ2Qk7pDv6dB5VHhmKsItG5YwNpZsWvjXP29YcSB07VooqElyQ4W vq/mu/ew2RpblVFcws4e5MqofXEwNxpFcJS3r+1Q= From: Thomas Jost To: Austin Clements Subject: Re: [PATCH] emacs: Let the user choose where to compose new mails In-Reply-To: References: <87pqhlh64c.fsf@thor.loria.fr> <1319528464-22654-1-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.9+66~g79e6e2e (http://notmuchmail.org) Emacs/24.0.90.1 (x86_64-unknown-linux-gnu) Date: Wed, 09 Nov 2011 19:50:55 +0100 Message-ID: <87ipmt8700.fsf@schnouki.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2011 18:51:02 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 4 Nov 2011 23:51:55 -0400, Austin Clements wrote: > This seems like a good option to have, but your approach seems > unnecessarily complicated. I'm always wary of defcustom's :set because > it means you can't just setq the variable, which defeats the > underlying beauty of the customize system. Actually I use it with setq without any problem. But yes, it's too complicated... > You could eliminate the other two variables and compute them on the > fly, or, if you really feel they may need to be controlled > independently, make the custom variable a pair or alist (which you can > hide behind a few const choices). Computing them on the fly is probably cleaner. But I'm not sure if the switch-function and dedicated flag must be independent or not. From what I've tested it's *much* more pleasant to use with the dedicated flag, but I don't know how other people feel about this... > Alternatively, it seems like the variable could instead > take a single function (basically what notmuch-mua-switch-function is > now) and you could provide two new functions that simply combine > switch-to-buffer-other-x and set-window-dedicated-p. I've tried that, but for some reason it doesn't work when forwarding a message: the dedicated flag is reset somewhere inside message-forward, but I don't know where nor why. (I haven't investigated much though.) > The defcustom would be more user-friendly if it gave a choice between > const values, rather than requiring the user to enter a symbol value > (and then possibly rejecting it on validation). Something like > :type '(choice (const :tag "Compose in the current window" current-wind= ow) > (const :tag "Compose mail in a new window" new-window) > (const :tag "Compose mail in a new frame" new-frame)) Yep, that's much better. I'll try to rewrite this patch using this and on-the-fly computations of the switch-function and dedicated flag. Thank you for the review! Regards, =2D-=20 Thomas/Schnouki --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOusuPAAoJEMPdciX+bh5Ib1AH/0xzI3WK64F9CxZ/gucsFPgp hmIDbEIavRe2fxcv74PiTtRvA/QgQU490jp2zMo+EySlMulRNgoONMZYS+dd/6Fz 1Uz3lzqtXLLvHQI/1FKQdQLo+VoBMtsP7IetYlO5pFzoQElrCTe6ST/CIgvqsqkW 4Pg5BMon8ZjzNht2SLIizrUVCRFnB6VU0YrLfYDQt0Xigbok+3reUJoVLl8UNl1w m2Ug+eyx9DiGfE4zVackd27EQdRQgwLavw92eqmJYS06EhrP71CheTFEJy++3Vxo 6ko8XzGWJsYPUDBQrDHzDQdRcMmCo15kJD+NQmG5/rRvmGScBiXHqsF+7XleZBU= =RQQA -----END PGP SIGNATURE----- --=-=-=--