unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.
Date: Sun, 15 Apr 2012 18:25:05 +0100	[thread overview]
Message-ID: <87iph06h72.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1326826969-23545-1-git-send-email-jrollins@finestructure.net>

On Tue, 17 Jan 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> No functional change here.  The help message previously referred to
> the "delete" tag, but "deleted" is now preferred, so hopefully this
> will reduce any potential confusion.

This patch is trivially correct regardless of the rest of the
series. 

I think the rest of the series (which provides keybindings for
adding/removing the delete tag to messages/threads) is worthwhile
particularly now the exclude stuff is fairly complete (feedback at the
time looked positive).

Patch 2/3 needs simple but genuine rebasing as the names of the
tagging functions have changed though. 

Best wishes

Mark

> ---
>  emacs/notmuch.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index e4bca51..67ecd3a 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>  Here is an example of how to color search results based on tags.
>   (the following text would be placed in your ~/.emacs file):
>  
> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>  						  :background \"blue\"))
>                                     (\"unread\" . (:foreground \"green\"))))
>  
>  The attributes defined for matching tags are merged, with later
> -attributes overriding earlier. A message having both \"delete\"
> +attributes overriding earlier. A message having both \"deleted\"
>  and \"unread\" tags with the above settings would have a green
>  foreground and blue background."
>    :type '(alist :key-type (string) :value-type (custom-face-edit))
> -- 
> 1.7.7.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2012-04-15 17:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-17 19:01 on deleting messages Jameson Graef Rollins
2012-01-17 19:02 ` [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name Jameson Graef Rollins
2012-01-17 19:02   ` [PATCH 2/3] emacs: message/thread deletion by adding "deleted" tag Jameson Graef Rollins
2012-01-17 19:02     ` [PATCH 3/3] emacs: add delete key bindings for search and show mode Jameson Graef Rollins
2012-04-15 17:25   ` Mark Walters [this message]
2012-04-15 17:39     ` [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name Tomi Ollila
2012-04-15 20:06     ` Jameson Graef Rollins
2012-04-16  5:13       ` Tomi Ollila
2012-04-16  5:46         ` Jameson Graef Rollins
2012-04-16  7:02           ` Tomi Ollila
2012-04-25  2:30   ` David Bremner
2012-01-17 20:21 ` on deleting messages Jani Nikula
2012-01-18  7:30   ` Tomi Ollila
2012-01-17 22:31 ` Xavier Maillard
2012-01-18  7:44 ` Antoine Beaupré
2012-01-18  8:18 ` David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iph06h72.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).