From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Mike Kelly <pioto@pioto.org>, notmuch@notmuchmail.org
Subject: Re: FreeBSD Support Patches
Date: Fri, 25 May 2012 18:15:57 +0400 [thread overview]
Message-ID: <87ipfktkgy.fsf@gmail.com> (raw)
In-Reply-To: <1337953411-21000-1-git-send-email-pioto@pioto.org>
Hi Mike.
Mike Kelly <pioto@pioto.org> writes:
> Hi,
>
> These patches add some changes necessary for a clean build on FreeBSD,
> and for most of the tests to pass.
>
> Also mixed in are a few patches to disable emacs tests when you don't
> have emacs, along with tests that depend upon emacs. I could split those
> off onto a separate branch if required.
>
Why do we need to explicitly declare Emacs dependency for tests? There
should be no need for it. We have "implicit" dependencies which are
declared once (see test_declare_external_prereq calls at the end of
test-lib.sh) and are automatically handled when a test tries to use a
missing binary. Explicit dependencies are hard to maintain (e.g. your
patch adds explicit emacs dependency for crypto test but misses gpg).
With rare exceptions we should not use explicit dependencies.
Regards,
Dmitry
> You can find the latest version of these patches on my github repo's
> fbsd-support branch:
>
> https://github.com/pioto/notmuch/compare/master...fbsd-support
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-05-25 14:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 13:43 FreeBSD Support Patches Mike Kelly
2012-05-25 13:43 ` [PATCH 01/10] Add support for FreeBSD Mike Kelly
2012-05-25 13:43 ` [PATCH 02/10] Fix compilation of symbol-test on FreeBSD Mike Kelly
2012-05-25 13:43 ` [PATCH 03/10] Fix compilation of smtp-dummy " Mike Kelly
2012-05-26 9:52 ` Jani Nikula
2012-05-25 13:43 ` [PATCH 04/10] Test against man pages in our source dir, not installed ones Mike Kelly
2012-05-25 13:43 ` [PATCH 05/10] Make test/basic more portable Mike Kelly
2012-05-25 13:43 ` [PATCH 06/10] Fix test/count on FreeBSD Mike Kelly
2012-05-26 2:42 ` Peter Wang
2012-05-25 13:43 ` [PATCH 07/10] emacs tests require emacs Mike Kelly
2012-05-25 13:43 ` [PATCH 08/10] test/atomicity: use a more portable 'cp' form Mike Kelly
2012-05-25 13:43 ` [PATCH 09/10] test/crypto: current tests require emacs Mike Kelly
2012-05-25 13:43 ` [PATCH 10/10] tests: bsd sed doesn't allow replacing '\n' Mike Kelly
2012-05-25 14:15 ` Dmitry Kurochkin [this message]
2012-05-25 20:02 ` FreeBSD Support Patches Mike Kelly
2012-05-26 1:07 ` Dmitry Kurochkin
2012-05-25 20:53 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipfktkgy.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=pioto@pioto.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).