From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] test: Add a test for HTML email with inline images
Date: Wed, 03 Oct 2012 18:41:07 +0400 [thread overview]
Message-ID: <87iparwrcs.fsf@gmail.com> (raw)
In-Reply-To: <20121003142834.GC14861@mit.edu>
Austin Clements <amdragon@MIT.EDU> writes:
> Quoth Dmitry Kurochkin on Oct 03 at 1:35 pm:
>> Hi Austin.
>>
>> Austin Clements <amdragon@MIT.EDU> writes:
>>
>> > Currently this test passes in Emacs 23 but fails in Emacs 24 (at least
>> > on some Linux distributions).
>>
>> The test fails for me on Emacs 23.4.1 (Debian unstable):
>>
>> FAIL Rendering HTML mail with images
>> --- emacs.51.OUTPUT 2012-10-03 09:31:33.383529764 +0000
>> +++ emacs.51.EXPECTED 2012-10-03 09:31:33.383529764 +0000
>> @@ -6,4 +6,3 @@
>> [ multipart/related ]
>> [ text/html ]
>> *
>> -
>>
>> Did not look into details.
>
> Yes. This test is (in hindsight, unsurprisingly) sensitive to
> whatever HTML renderer Emacs chooses. It looks like you're probably
> using html2text, which outputs nothing for an image. Unfortunately,
> none of the built-in renderers in Emacs 23 are aware of content
> references, which makes this test rather pointless on Emacs 23 unless
> we depend on an external renderer.
>
> The best solution I can think of dynamically chooses shr on Emacs 24
> (since that's really what we're trying to test) and gives up on Emacs
> 23 and forcibly selects html2text (test patch below). Alternatively,
> we could cycle through all of the available renderers, test everything
> that we can, and just ignore everything that we can't run, though that
> would make the test environment-sensitive.
>
Perhaps the test should be skipped if shr is not available, like we do
for missing binaries?
Regards,
Dmitry
> diff --git a/test/emacs b/test/emacs
> index 1f84b91..2ef78bf 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -756,7 +756,7 @@ add_message '[subject]="HTML mail with images"' \
> '[body]="--abcd
> Content-Type: text/html
>
> -<img src="cid:330@goomoji.gmail">
> +<img src="cid:330@goomoji.gmail"> smiley
>
> --abcd
> Content-Type: image/gif
> @@ -766,10 +766,13 @@ Content-ID: <330@goomoji.gmail>
> R0lGODlhDAAMAKIFAF5LAP/zxAAAANyuAP/gaP///wAAAAAAACH5BAEAAAUALAAAAAAMAAwAAAMl
> WLPcGjDKFYi9lxKBOaGcF35DhWHamZUW0K4mAbiwWtuf0uxFAgA7
> --abcd--"'
> -test_emacs "(notmuch-show \"id:${gen_msg_id}\")
> +test_emacs "(let ((mm-text-html-renderer
> + (if (assq 'shr mm-text-html-renderer-alist)
> + 'shr 'html2text)))
> + (notmuch-show \"id:${gen_msg_id}\"))
> (test-output)"
> # Normalize output for Emacs 23 and Emacs 24
> -sed -i 's/\[cid\]/*/' OUTPUT
> +sed -i 's/^ smiley/* smiley/' OUTPUT
> cat <<EOF >EXPECTED
> Notmuch Test Suite <test_suite@notmuchmail.org> (2001-01-05) (inbox)
> Subject: HTML mail with images
> @@ -778,7 +781,7 @@ Date: Fri, 05 Jan 2001 15:43:57 +0000
>
> [ multipart/related ]
> [ text/html ]
> -*
> +* smiley
> EOF
> test_expect_equal_file OUTPUT EXPECTED
>
next prev parent reply other threads:[~2012-10-03 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 17:55 [PATCH 0/3] Fix gnus-inhibit-images bug in Emacs 24 Austin Clements
2012-09-29 17:55 ` [PATCH 1/3] test: Clear test-ouput output file before running Emacs tests Austin Clements
2012-09-29 17:55 ` [PATCH 2/3] test: Add a test for HTML email with inline images Austin Clements
2012-10-03 9:35 ` Dmitry Kurochkin
2012-10-03 14:28 ` Austin Clements
2012-10-03 14:41 ` Dmitry Kurochkin [this message]
2012-09-29 17:55 ` [PATCH 3/3] emacs: Work around gnus-inhibit-images bug in mm-shr Austin Clements
2012-09-29 18:03 ` [PATCH] " Austin Clements
2012-09-29 20:26 ` [PATCH 0/3] Fix gnus-inhibit-images bug in Emacs 24 Tomi Ollila
2012-10-01 2:38 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iparwrcs.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).