From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: make show-get-message-prop usable from pick
Date: Mon, 03 Dec 2012 01:22:53 +0000 [thread overview]
Message-ID: <87ip8kszde.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1354486881-32456-1-git-send-email-markwalters1009@gmail.com>
Hi
On Sun, 02 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Make notmuch-show-get-prop choose the get-message-properties routine
> based on the major mode. This make it usable from notmuch-pick and
> thus a large number of functions are usable directly from
> notmuch-show.el and do not need to be reimplemented in pick.
> ---
>
> Ok so the previous version was me being stupid. I was wanting to avoid
> errors caused by notmuch-pick-get-message-properties not existing but
> the obvious solution is just to define it in a trivial fashion as
> here.
and to continue the stupidity the first hunk is no longer needed: it's
just the second hunk now.
MW
>
> Anyway would this be acceptable?
>
> Best wishes
>
> Mark
>
>
> emacs/notmuch-show.el | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 4d6c014..b7f64e3 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1378,6 +1378,10 @@ Some useful entries are:
> (notmuch-show-move-to-message-top)
> (get-text-property (point) :notmuch-message-properties)))
>
> +(defun notmuch-show-mode-get-message-properties ()
> + "Wrapper for notmuch-show-get-message-properties"
> + (notmuch-show-get-message-properties))
> +
> (defun notmuch-show-set-prop (prop val &optional props)
> (let ((inhibit-read-only t)
> (props (or props
> @@ -1385,9 +1389,13 @@ Some useful entries are:
> (plist-put props prop val)
> (notmuch-show-set-message-properties props)))
>
> +(defun notmuch-pick-get-message-properties ())
> +
> (defun notmuch-show-get-prop (prop &optional props)
> (let ((props (or props
> - (notmuch-show-get-message-properties))))
> + (if (eq major-mode 'notmuch-show-mode)
> + (notmuch-show-get-message-properties)
> + (notmuch-pick-get-message-properties)))))
> (plist-get props prop)))
>
> (defun notmuch-show-get-message-id (&optional bare)
> --
> 1.7.9.1
next prev parent reply other threads:[~2012-12-03 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 21:29 [RFC PATCH] emacs: show: make show-get-message-prop usable from pick Mark Walters
2012-12-02 22:21 ` [PATCH] " Mark Walters
2012-12-03 1:22 ` Mark Walters [this message]
2012-12-07 8:09 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip8kszde.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).