unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/5] util: Function to parse boolean term queries
Date: Tue, 25 Dec 2012 10:34:19 -0400	[thread overview]
Message-ID: <87ip7qdwus.fsf@zancas.localnet> (raw)
In-Reply-To: <87obhidxkt.fsf@zancas.localnet>

David Bremner <david@tethera.net> writes:
>
> So if there is no quote, we skip the part after the ':'? I guess I
> probably missed something because that doesn't sound like the intended
> behaviour.

Indeed the following addition to the test shows it works fine in
context. So I guess I just don't follow this control flow very well.

diff --git a/test/dump-restore b/test/dump-restore
index aecc393..f9ae5b3 100755
--- a/test/dump-restore
+++ b/test/dump-restore
@@ -200,6 +200,8 @@ a
 # the next non-comment line should report an an empty tag error for
 # batch tagging, but not for restore
 + +e -- id:20091117232137.GA7669@griffis1.net
+# valid id, but warning about missing message
++e id:missing_message_id
 EOF
 
 cat <<EOF > EXPECTED
@@ -211,6 +213,7 @@ Warning: no query string after -- [+c +d --]
 Warning: hex decoding of tag %zz failed [+%zz -- id:whatever]
 Warning: cannot parse query: id:"
 Warning: not an id query: tag:abc
+Warning: cannot apply tags to missing message: missing_message_id
 EOF
 
 test_expect_equal_file EXPECTED OUTPUT

  reply	other threads:[~2012-12-25 14:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-25  5:57 [PATCH 0/5] Use Xapian query syntax for batch-tag dump/restore Austin Clements
2012-12-25  5:57 ` [PATCH 1/5] util: Factor out boolean term quoting routine Austin Clements
2012-12-25 12:25   ` David Bremner
2012-12-25  5:57 ` [PATCH 2/5] util: Function to parse boolean term queries Austin Clements
2012-12-25 14:18   ` David Bremner
2012-12-25 14:34     ` David Bremner [this message]
2012-12-26  1:23     ` Austin Clements
2012-12-25  5:57 ` [PATCH 3/5] dump: Disallow \n in message IDs Austin Clements
2012-12-25 14:21   ` David Bremner
2012-12-25  5:57 ` [PATCH 4/5] dump/restore: Use Xapian queries for batch-tag format Austin Clements
2012-12-25  5:57 ` [PATCH 5/5] man: Update notmuch-dump(1) for new " Austin Clements
2012-12-25 14:47   ` David Bremner
2012-12-25 15:18     ` David Bremner
2012-12-25 18:05   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip7qdwus.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).