From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 75A15431FBC for ; Thu, 3 Jan 2013 11:59:49 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 020aWyfb0CKt for ; Thu, 3 Jan 2013 11:59:45 -0800 (PST) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 57065431FAF for ; Thu, 3 Jan 2013 11:59:45 -0800 (PST) Received: by mail-wg0-f52.google.com with SMTP id 12so7385423wgh.7 for ; Thu, 03 Jan 2013 11:59:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:x-gm-message-state; bh=XBS8Vx9BgJZgPwnZKEQ9l92RV5Ye9VFIi2BxaRkHceg=; b=hUIOtdJkQDM8PctNz0kY59kcWdyrXvkZg2j0kWiEUY5qK+64MoNUSsqKH9yRnL8PhL 1Rn7uwvBOEe8wXNt+S2heOn7KiHRke0KpBc3YyoI1mMt+GlhkQ+85EcvwFNYQY6nhJiv 3koAip/WEpfaJnAFiFX/CRLw8bmk5gYijLWGgfhHsYP2feebSQJ3QSVk+13Zkr9FoBFF pcHtmRfWxmLIPqnBJw+Idvg0I1x5/DtETwyIKG3TMKKXyClJsLxNXcY9RgMiKj1/uSJB j+xzAVr2NvT5s/ScjLlz7hJis2/1AkyLdJ9mFYBJkV3qwkDtbagR39dhFl0dAw2Ham+T mw2w== X-Received: by 10.194.90.238 with SMTP id bz14mr71511147wjb.9.1357243184273; Thu, 03 Jan 2013 11:59:44 -0800 (PST) Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) by mx.google.com with ESMTPS id ex6sm86919064wid.3.2013.01.03.11.59.42 (version=SSLv3 cipher=OTHER); Thu, 03 Jan 2013 11:59:43 -0800 (PST) From: Jani Nikula To: david@tethera.net, notmuch@notmuchmail.org Subject: Re: Xapian-quoting based batch-tagging. In-Reply-To: <1356464567-21779-1-git-send-email-david@tethera.net> References: <1356464567-21779-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.14+235~gdaf492b (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) Date: Thu, 03 Jan 2013 20:59:36 +0100 Message-ID: <87ip7eghqv.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQm57XiI/f3azGcldwyB9o6HcKDUndm7ki9pI/Bup88httpyRjiNvMURM4lnGKEvNkIHcuR5 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 19:59:49 -0000 On Tue, 25 Dec 2012, david@tethera.net wrote: > This is an alternative version of > > id:1356313183-9266-1-git-send-email-david@tethera.net > > batch tagging patches rebased on top of > > id:1356415076-5692-1-git-send-email-amdragon@mit.edu I didn't go through this quite as thoroughly as the previous versions, but the series LGTM. I like how this simplifies things. In the future, I'd like us to support xapian quoting also in the tag changes, for consistency. BR, Jani. > > This mainly consisted of removing > > [Patch v9 04/17] notmuch-tag: factor out double quoting routine > (superceded by one of Austin's patches) > > [Patch v9 05/17] util/string-util: add a new string tokenized function > [Patch v9 06/17] unhex_and_quote: new function to quote hex-decoded queries > [Patch v9 07/17] notmuch-restore: move query handling for batch > (uneeded if query is passed verbatim to xapian) > > I also removed two tests, since they are about how we handle > quoting: > > [Patch v9 13/17] test/tagging: add test for compound queries with batch tagging > [Patch v9 17/17] test/tagging: add test for handling of parenthesized tag queries. > > A few small fixes were needed to the tests, and a fair amount of > changes to the notmuch-tag man page. > > Diffstat (against Austin's series) is as follows > > man/man1/notmuch-tag.1 | 99 ++++++++++++++++++++- > notmuch-tag.c | 169 ++++++++++++++++++++---------------- > tag-util.c | 87 +++++++++++++++++-- > tag-util.h | 15 ++++ > test/tagging | 195 ++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 480 insertions(+), 85 deletions(-) > > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch