unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch
Date: Thu, 04 Jul 2013 09:07:24 +0100	[thread overview]
Message-ID: <87ip0qg343.fsf@qmul.ac.uk> (raw)
In-Reply-To: <m2zju2lqpy.fsf@guru.guru-group.fi>


Tomi Ollila <tomi.ollila@iki.fi> writes:

> FWIW the code LGTM. Do the pick tests use this and do those pass ?

Thanks for the review.

The tests do all pass. There are two sets of pick tests: one uses the
async parser (the default) which uses this code and the other uses the
sync parser (which probably should be removed as the async parser seems
stable).

Best wishes

Mark






>
> Tomi
>
>>
>> Best wishes
>>
>> Mark
>>
>>
>>  contrib/notmuch-pick/notmuch-pick.el |    7 +++----
>>  1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
>> index fbd7c0b..7f5f729 100644
>> --- a/contrib/notmuch-pick/notmuch-pick.el
>> +++ b/contrib/notmuch-pick/notmuch-pick.el
>> @@ -817,16 +817,15 @@ Complete list of currently available key bindings:
>>      (if (equal (car (process-lines notmuch-command "count" search-args)) "0")
>>  	(setq search-args basic-query))
>>      (if notmuch-pick-asynchronous-parser
>> -	(let ((proc (start-process
>> -		     "notmuch-pick" buffer
>> -		     notmuch-command "show" "--body=false" "--format=sexp"
>> +	(let ((proc (notmuch-start-notmuch
>> +		     "notmuch-pick" buffer #'notmuch-pick-process-sentinel
>> +		     "show" "--body=false" "--format=sexp"
>>  		     message-arg search-args))
>>  	      ;; Use a scratch buffer to accumulate partial output.
>>                ;; This buffer will be killed by the sentinel, which
>>                ;; should be called no matter how the process dies.
>>                (parse-buf (generate-new-buffer " *notmuch pick parse*")))
>>            (process-put proc 'parse-buf parse-buf)
>> -	  (set-process-sentinel proc 'notmuch-pick-process-sentinel)
>>  	  (set-process-filter proc 'notmuch-pick-process-filter)
>>  	  (set-process-query-on-exit-flag proc nil))
>>        (progn
>> -- 
>> 1.7.9.1
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2013-07-04  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  7:09 [PATCH] contrib: pick: use notmuch-start-notmuch Mark Walters
2013-07-04  7:38 ` Tomi Ollila
2013-07-04  8:07   ` Mark Walters [this message]
2013-07-20 17:31 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip0qg343.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).