[PATCH] emacs: update alist for mail-archive.com API change

[PATCH] emacs: update alist for mail-archive.com API change

[Jed Brown]

Searching by Message-Id no longer works via the old mail-archive.com
API, though I have contacted them in hopes that they restore it to
prevent dead links.  Anyway, the new API is cleaner.
---
 emacs/notmuch-show.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1ac80ca..88752f1 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
 (defcustom notmuch-show-stash-mlarchive-link-alist
   '(("Gmane" . "http://mid.gmane.org/")
     ("MARC" . "http://marc.info/?i=")
-    ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
+    ("Mail Archive, The" . "http://mid.mail-archive.com/")
     ("LKML" . "http://lkml.kernel.org/r/")
     ;; FIXME: can these services be searched by `Message-Id' ?
     ;; ("MarkMail" . "http://markmail.org/")
-- 
1.8.5.4

Re: [PATCH] emacs: update alist for mail-archive.com API change

[Austin Clements]

On Wed, 12 Feb 2014, Jed Brown <jed@jedbrown.org> wrote:
> Searching by Message-Id no longer works via the old mail-archive.com
> API, though I have contacted them in hopes that they restore it to
> prevent dead links.  Anyway, the new API is cleaner.
> ---
>  emacs/notmuch-show.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 1ac80ca..88752f1 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
>  (defcustom notmuch-show-stash-mlarchive-link-alist
>    '(("Gmane" . "http://mid.gmane.org/")
>      ("MARC" . "http://marc.info/?i=")
> -    ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
> +    ("Mail Archive, The" . "http://mid.mail-archive.com/")
>      ("LKML" . "http://lkml.kernel.org/r/")
>      ;; FIXME: can these services be searched by `Message-Id' ?
>      ;; ("MarkMail" . "http://markmail.org/")
> -- 
> 1.8.5.4

LGTM.

Curiously, if you go to just http://mid.mail-archive.com/, it redirects
to http://www.mail-archive.com/search?l=mid&q=message-id%3A%5C, which
suggests to me that they did not intend to break the old URLs.  But I
agree that the new API is nicer (and produces shorter URLs).

Re: [PATCH] emacs: update alist for mail-archive.com API change

[David Bremner]

Jed Brown <jed@jedbrown.org> writes:

> -    ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
> +    ("Mail Archive, The" . "http://mid.mail-archive.com/")

the change looks reasonable, but it breaks one of the tests.

Please update the corresponding test at the same time.

d

[PATCH] emacs: update alist for mail-archive.com API change

[Jed Brown]

Searching by Message-Id no longer works via the old mail-archive.com
API, though I have contacted them in hopes that they restore it to
prevent dead links.  Anyway, the new API is cleaner.

Acked-by: Austin Clements <amdragon@MIT.EDU>
---
Fixed the test.  Thanks, David.

 emacs/notmuch-show.el | 2 +-
 test/T310-emacs.sh    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1ac80ca..88752f1 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
 (defcustom notmuch-show-stash-mlarchive-link-alist
   '(("Gmane" . "http://mid.gmane.org/")
     ("MARC" . "http://marc.info/?i=")
-    ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
+    ("Mail Archive, The" . "http://mid.mail-archive.com/")
     ("LKML" . "http://lkml.kernel.org/r/")
     ;; FIXME: can these services be searched by `Message-Id' ?
     ;; ("MarkMail" . "http://markmail.org/")
diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index 7dc9a8e..00ae96a 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -727,7 +727,7 @@ inbox,stashtest
 ${gen_msg_filename}
 http://mid.gmane.org/bought
 http://marc.info/?i=bought
-http://mail-archive.com/search?l=mid&q=bought
+http://mid.mail-archive.com/bought
 EOF
 test_expect_equal_file OUTPUT EXPECTED
 
-- 
1.8.5.4

Re: [PATCH] emacs: update alist for mail-archive.com API change

[David Bremner]

Jed Brown <jed@jedbrown.org> writes:

> Searching by Message-Id no longer works via the old mail-archive.com
> API, though I have contacted them in hopes that they restore it to
> prevent dead links.  Anyway, the new API is cleaner.
>
> Acked-by: Austin Clements <amdragon@MIT.EDU>
> ---
> Fixed the test.  Thanks, David.

pushed, thanks

d