From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [Patch v5 05/11] lib: provide config API
Date: Tue, 24 May 2016 08:48:11 -0300 [thread overview]
Message-ID: <87iny3n0ck.fsf@zancas.localnet> (raw)
In-Reply-To: <1463135893-7471-6-git-send-email-david@tethera.net>
David Bremner <david@tethera.net> writes:
> + notmuch->exception_reported = TRUE;
> + if (! notmuch->exception_reported) {
> + _notmuch_database_log (notmuch, "Error: A Xapian exception occurred setting metadata: %s\n",
> + error.get_msg().c_str());
> + }
Upon revisiting, this looks pretty silly. According to the commit
message in e2341cb the point of exception_reported is to avoid excess
error reporting when closing/flushing after another error. Since we
don't actually print these error messages anymore, I'm not sure it's
even needed. In any case, this is a bad case of copy-pasta, which I've
fixed in git by removing the if (in both places).
next prev parent reply other threads:[~2016-05-24 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 10:38 version 5 of libconfig / single argument date / named query patches David Bremner
2016-05-13 10:38 ` [Patch v5 01/11] configure: detect Xapian:FieldProcessor David Bremner
2016-05-13 10:38 ` [Patch v5 02/11] lib: optionally support single argument date: queries David Bremner
2016-05-13 10:38 ` [Patch v5 03/11] lib/cli: add library API / CLI for compile time options David Bremner
2016-05-13 10:38 ` [Patch v5 04/11] configure: check directly for xapian compaction API David Bremner
2016-05-14 0:12 ` David Bremner
2016-05-13 10:38 ` [Patch v5 05/11] lib: provide config API David Bremner
2016-05-24 11:48 ` David Bremner [this message]
2016-05-13 10:38 ` [Patch v5 06/11] lib: config list iterators David Bremner
2016-05-24 11:54 ` David Bremner
2016-05-13 10:38 ` [Patch v5 07/11] CLI: add optional config data to dump output David Bremner
2016-05-13 10:38 ` [Patch v5 08/11] CLI: optionally restore config data David Bremner
2016-05-13 10:38 ` [Patch v5 09/11] CLI: add notmuch-config support for named queries David Bremner
2016-05-13 10:38 ` [Patch v5 10/11] lib: make a global constant for query parser flags David Bremner
2016-05-13 10:38 ` [Patch v5 11/11] lib: add support for named queries David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iny3n0ck.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).