[PATCH] configure: set platform variables also when `uname` is unrecognized

[PATCH] configure: set platform variables also when `uname` is unrecognized

[Tomi Ollila]

Since commit

124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u

all variables must be set before their expansion are attempted. These
2 variables: "platform" and "linker_resolves_library_dependencies" were
not given value in the final 'else' branch when platform check failed
due to unrecognized kernel name (output of `uname`). Now those two are
given reasonable non-empty values.
---

Unfortunately I did not catch these 2 while doing 124a67e96ecab5; That
else branch just skipped my radar. Now I also (re-)looked all other
if/then/elif/else/fi parts to catch any other similar potential problems,
and did not notice anything.

 configure | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configure b/configure
index fa4c5b5..cc6746c 100755
--- a/configure
+++ b/configure
@@ -650,6 +650,8 @@ elif [ $uname = "Linux" ] || [ $uname = "GNU" ] ; then
     fi
 else
     printf "Unknown.\n"
+    platform="$uname"
+    linker_resolves_library_dependencies=0
     cat <<EOF
 
 *** Warning: Unknown platform. Notmuch might or might not build correctly.
-- 
2.7.4

Re: [PATCH] configure: set platform variables also when `uname` is unrecognized

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Since commit
>
> 124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u
>
> all variables must be set before their expansion are attempted. These
> 2 variables: "platform" and "linker_resolves_library_dependencies" were
> not given value in the final 'else' branch when platform check failed
> due to unrecognized kernel name (output of `uname`). Now those two are
> given reasonable non-empty values.
> ---

I tested on Debian/kfreebsd-amd64 and this seems to fix the build
failure in 0.23~rc0

f

Re: [PATCH] configure: set platform variables also when `uname` is unrecognized

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Since commit
>
> 124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u
>
> all variables must be set before their expansion are attempted. These
> 2 variables: "platform" and "linker_resolves_library_dependencies" were
> not given value in the final 'else' branch when platform check failed
> due to unrecognized kernel name (output of `uname`). Now those two are
> given reasonable non-empty values.

pushed to release and master

d