From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id F419C6DE1029
 for <notmuch@notmuchmail.org>; Thu, 28 Mar 2019 06:20:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.019
X-Spam-Level: 
X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5
 tests=[AWL=-0.018, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id g5rrXfo9hKv7 for <notmuch@notmuchmail.org>;
 Thu, 28 Mar 2019 06:20:05 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 40E2A6DE101A
 for <notmuch@notmuchmail.org>; Thu, 28 Mar 2019 06:20:05 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1h9Uwu-0004fC-Cs; Thu, 28 Mar 2019 09:20:04 -0400
Received: (nullmailer pid 19603 invoked by uid 1000);
 Thu, 28 Mar 2019 13:20:03 -0000
From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the
 current message
In-Reply-To: <m2mulfjkqd.fsf@dme.org>
References: <20181108104508.84911-1-dme@dme.org> <874l7nz1hi.fsf@tethera.net>
 <m2mulfjkqd.fsf@dme.org>
Date: Thu, 28 Mar 2019 10:20:03 -0300
Message-ID: <87imw39lvg.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Mar 2019 13:20:06 -0000

David Edmondson <dme@dme.org> writes:

> On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote:
>
>> David Edmondson <dme@dme.org> writes:
>>
>>
>>> +(defun notmuch-show--browse-urls ()
>>> +  "Offer to browse any URLs in the current message."
>>> +  (interactive)
>>> +  (let ((urls (notmuch-show--gather-urls)))
>>> +    (if urls
>>> +	(browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car urls)))
>>> +      (message "No URLs found."))))
>>> +
>>>  (provide 'notmuch-show)
>>
>> It's a minor point, but should this really have -- to signal a private
>> function? It's bound to key which sortof makes it defacto public, no?
>
> Yes.
>
> Do you want an updated patch or will you fix it on the fly?
>

I can fix it.

d