From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local
Date: Sun, 10 May 2020 14:03:17 -0400 [thread overview]
Message-ID: <87imh3mzve.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87r1vtib41.fsf@tethera.net>
[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]
On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote:
> I'm confused about where to apply 2/2. If I apply it on top of (updated)
> master, it causes test failures. If I apply after the rest of the
> patches in this thread then presumably there is some interval where the
> build is broken (if only for certain GMime versions).
yes, that's right. For certain GMime versions, there's an intermediate
breakage. I think you're saying you want me to rerun the series, with
these things split out so that even on systems with older GMime, tests
pass at every commit. I'll try to get that done today.
--dkg
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2020-05-10 18:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:13 Handle PKCS#7 S/MIME messages Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 1/9] lib: index PKCS7 SignedData parts Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 2/9] smime: Identify encrypted S/MIME parts during indexing Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 3/9] cli: include wrapped part of PKCS#7 SignedData in the MIME tree Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 4/9] cli/show: If a leaf part has children, show them instead of omitting Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 5/9] cli/reply: Ignore PKCS#7 wrapper parts when replying Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 6/9] crypto: Make _notmuch_crypto_decrypt take a GMimeObject Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 7/9] crypto: handle PKCS#7 envelopedData in _notmuch_crypto_decrypt Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 8/9] smime: Pass PKCS#7 envelopedData to node_decrypt_and_verify Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 9/9] smime: Index cleartext of envelopedData when requested Daniel Kahn Gillmor
2020-05-01 21:15 ` Handle PKCS#7 S/MIME messages Tomi Ollila
2020-05-04 19:16 ` Daniel Kahn Gillmor
2020-05-05 8:32 ` Tomi Ollila
2020-05-05 18:07 ` David Bremner
2020-05-06 23:54 ` [PATCH 1/2] test-lib: mark function variables as local Daniel Kahn Gillmor
2020-05-06 23:54 ` [PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 Daniel Kahn Gillmor
2020-05-07 20:54 ` Tomi Ollila
2020-05-12 22:20 ` [PATCH 2/2 v2] " Daniel Kahn Gillmor
2020-05-21 23:29 ` David Bremner
2020-05-22 0:41 ` Daniel Kahn Gillmor
2020-05-22 0:42 ` [PATCH 2/2 v3] " Daniel Kahn Gillmor
2020-05-23 11:56 ` David Bremner
2020-05-07 7:31 ` [PATCH 1/2] test-lib: mark function variables as local Tomi Ollila
2020-05-08 20:04 ` Daniel Kahn Gillmor
2020-05-08 23:24 ` [PATCH 1/2 v2] " Daniel Kahn Gillmor
2020-05-09 7:09 ` Tomi Ollila
2020-05-09 11:47 ` David Bremner
2020-05-10 18:03 ` Daniel Kahn Gillmor [this message]
2020-05-10 19:02 ` David Bremner
2020-05-12 22:14 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imh3mzve.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).