unofficial mirror of notmuch@notmuchmail.org
 help / color / Atom feed
* [PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required
       [not found] <20200624201120.31049-1-tomi.ollila@iki.fi>
@ 2020-06-24 20:11 ` Tomi Ollila
  2020-06-27  1:25 ` David Bremner
  1 sibling, 0 replies; 2+ messages in thread
From: Tomi Ollila @ 2020-06-24 20:11 UTC (permalink / raw)
  To: notmuch; +Cc: tomi.ollila

Since October 2018 building notmuch has actually required compiler
that knows C11.

Also this -std=gnu99 was not used in code compiled by configure,
so in theory this could have caused problems...

...but no related reports have been sent, perhaps ever.

Both gcc and clang has been shipping compilers supporting C11
(or later) by default for more than four years now.

Therefore, just dropping -std=gnu99 (and not checking C11
compatibility for now, for simplicity) is easiest to do,
and removes inconsistency between configure and build time
compilations.
---
 Makefile.global | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Makefile.global b/Makefile.global
index 0aee5876..98b6962e 100644
--- a/Makefile.global
+++ b/Makefile.global
@@ -49,8 +49,7 @@ DETACHED_SIG_FILE=$(TAR_FILE).asc
 PV_FILE=bindings/python/notmuch/version.py
 
 # Smash together user's values with our extra values
-STD_CFLAGS := -std=gnu99
-FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(STD_CFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
+FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
 FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS)
 FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lnotmuch_util -Llib -lnotmuch
 ifeq ($(LIBDIR_IN_LDCONFIG),0)
-- 
2.25.1

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required
       [not found] <20200624201120.31049-1-tomi.ollila@iki.fi>
  2020-06-24 20:11 ` [PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required Tomi Ollila
@ 2020-06-27  1:25 ` David Bremner
  1 sibling, 0 replies; 2+ messages in thread
From: David Bremner @ 2020-06-27  1:25 UTC (permalink / raw)
  To: Tomi Ollila, notmuch; +Cc: tomi.ollila

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Since October 2018 building notmuch has actually required compiler
> that knows C11.
>
> Also this -std=gnu99 was not used in code compiled by configure,
> so in theory this could have caused problems...
>

pushed.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200624201120.31049-1-tomi.ollila@iki.fi>
2020-06-24 20:11 ` [PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required Tomi Ollila
2020-06-27  1:25 ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

Archives are clonable:
	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git