unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Kyle Meyer <kyle@kyleam.com>, Matt Lundin <mdl@imapmail.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: restore tag-changes and query bindings for tag hooks
Date: Wed, 05 May 2021 10:42:25 -0300	[thread overview]
Message-ID: <87im3xl2ke.fsf@tethera.net> (raw)
In-Reply-To: <87sg319aqa.fsf@kyleam.com>

Kyle Meyer <kyle@kyleam.com> writes:

> +;; `dlet' isn't available until Emacs 28.1.  Below is a copy, with the
> +;; addition of `with-no-warnings'.
> +(defmacro notmuch-dlet (binders &rest body)
> +  "Like `let*' but using dynamic scoping."
> +  (declare (indent 1) (debug let))
> +  `(let (_)
> +     (with-no-warnings  ; Quiet "lacks a prefix" warning.
> +       ,@(mapcar (lambda (binder)
> +		   `(defvar ,(if (consp binder) (car binder) binder)))
> +		 binders))
> +     (let* ,binders ,@body)))
> +
>  (provide 'notmuch-compat)

What do you think Jonas, is this a reasonable approach?

d

      reply	other threads:[~2021-05-05 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 21:15 Bug (emacs): lexical binding breaks tag hooks Matt Lundin
2021-05-05  2:26 ` [PATCH] emacs: restore tag-changes and query bindings for " Kyle Meyer
2021-05-05 13:42   ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im3xl2ke.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=kyle@kyleam.com \
    --cc=mdl@imapmail.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).