Re: [PATCH] emacs: do not unconditionally set mail-user-agent

[webdev@toryanderson.com (Tory S. Anderson)]

This would be terrific on my account, with that user-agent problem. It seems reasonable to ask Notmuch to NOT mess with global settings unconditionally.

The one thing I wasn't sure about in what I saw of the changes of this patch is where the "conditional" option is. Usually when I've implemented something like this I just create a custom variable and IF that variable is something, then I do the new thing; otherwise do the old thing, thereby maintaining reverse-compatibility. I didn't see that pattern here, I'm not familiar with this medium of code discussion. 

I'm not familiar with how the git process goes here, since it's somewhat different than gitlab/github. Is there something I can do to apply this, or is there a separate notification for master, or should I subscribe to a different branch?

- Tory

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Thu, May 13 2021, David Bremner wrote:
>
>> A user that loads notmuch.el does not necessarily want to user
>> notmuch-message-mode to send mail.
>
> If this does not break anything, could be point release content,
> provided it did not ship yet (then to the next sailing ship...).
>
>> ---
>>  emacs/notmuch.el | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index 6d37c623..3e2713e2 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -1162,8 +1162,6 @@ Point should be at the beginning of the line."
>>  
>>  ;;; _
>>  
>> -(setq mail-user-agent 'notmuch-user-agent)
>> -
>>  (provide 'notmuch)
>>  
>>  ;; After provide to avoid loops if notmuch was require'd via notmuch-init-file.
>> -- 
>> 2.30.2
>> _______________________________________________
>> notmuch mailing list -- notmuch@notmuchmail.org
>> To unsubscribe send an email to notmuch-leave@notmuchmail.org
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org