From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id DH1pMo4lqWDgYgEAgWs5BA (envelope-from ) for ; Sat, 22 May 2021 17:38:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EOSILY4lqWDofQAAB5/wlQ (envelope-from ) for ; Sat, 22 May 2021 15:38:54 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE9E124D6A for ; Sat, 22 May 2021 17:38:53 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 569982AA46; Sat, 22 May 2021 11:38:48 -0400 (EDT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.164]) by mail.notmuchmail.org (Postfix) with ESMTPS id 300712AA17 for ; Sat, 22 May 2021 11:38:45 -0400 (EDT) Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D00A39D82C for ; Sat, 22 May 2021 10:38:43 -0500 (CDT) Received: from box2268.bluehost.com ([50.87.192.155]) by cmsmtp with SMTP id kTi7lUsCQnrr4kTi7lPX7Z; Sat, 22 May 2021 10:38:43 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=toryanderson.com; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Content-Transfer-Encoding:References:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fvVwskW3+FnH1jZfCFpXxHx6gXpjdiCrXYQfZyRoz/4=; b=krEIq+R/9xqjP/CTUIAf0+Xxr6 M3SYe+LAfBy3vZLhFKLDG8qHnibPgqCp73NqJHNKrdQ/xVK3hTwZPssqCV4+cfZVUTGyo84ojJayY Z/WSgBr8fJ+ttVS5qVXzEU69k3DcJHvSnzWQ7kcjU9h74WGikv1QnZLEQqiCzM146j3c=; Received: from c-98-33-162-63.hsd1.ut.comcast.net ([98.33.162.63]:45249 helo=localhost.localdomain) by box2268.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lkTi6-001mkR-W8; Sat, 22 May 2021 09:38:43 -0600 From: "Tory S. Anderson" To: Tomi Ollila Subject: Re: [PATCH] emacs: PATCH [1/2] mail user agent References: <87k0nuhfrk.fsf@toryanderson.com> <87pmxjt14b.fsf@tethera.net> Date: Sat, 22 May 2021 09:38:43 -0600 In-Reply-To: (Tomi Ollila's message of "Sat, 22 May 2021 16:28:46 +0300") Message-ID: <87im3alqws.fsf@toryanderson.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box2268.bluehost.com X-AntiAbuse: Original Domain - notmuchmail.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - toryanderson.com X-BWhitelist: no X-Source-IP: 98.33.162.63 X-Source-L: No X-Exim-ID: 1lkTi6-001mkR-W8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-98-33-162-63.hsd1.ut.comcast.net (localhost.localdomain) [98.33.162.63]:45249 X-Source-Auth: webdev@toryanderson.com X-Email-Count: 3 X-Source-Cap: dG9yeWFuZGU7dG9yeWFuZGU7Ym94MjI2OC5ibHVlaG9zdC5jb20= X-Local-Domain: yes Message-ID-Hash: E6SOTVS7ZNUUDVGPDDGFHEHIBSO3GITS X-Message-ID-Hash: E6SOTVS7ZNUUDVGPDDGFHEHIBSO3GITS X-MailFrom: webdev@toryanderson.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621697934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=aKYJYm9VaBrc4vMnuLCb0GmyBm9HuKKFt1pmKpJ+jmA=; b=hBEBDEoXCwBgIpouaUL2hUAt6sjjN7GpRjwQEPIgn+IBA76jPHu2sE0Z4ty6R0z+7OfOWS mJCD/IWaTy4CXjnTZlgTT2ud8ipQjqqluSv2v2yuPQVNZNKvfewoawITxUyOw0iPqb0ndc defj13hLA88AKJs1DxZKisNQQFJ5REbEj7SPOhdL/x4UvPQ5VawF80b0ToR9Uk1OO4NOCR WLLSCiI7o3YsKls9DZ02pMaHtokdZppBB1fF97HS1sAug79PBEHcUpfx1p8bRkI8eXpSov P2pj2OrRouSWzwZgitfxMCwQs2iIe+2F9e9xeHCyyMTtSs5qkuVRsm0swfkczw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621697934; a=rsa-sha256; cv=none; b=Q4NjGuL4UtSiF02jAv4B/5rSst/iBC2hOxOPx8H6vWNBw+mycQoqivUDc57idnmox+lW0w CNj/doizhL9Ic9ADa3lVkmRKe0rtAmYmZpWjsUTaNauBe7ktMxymHHKRXyy44SaQJ3GlO6 9oH2nfH99oUSdMLiofYXO6+46PUIgAUklmIYMMS79wmMj6oGBFhBs2+uJCLVAUFhdCEzcj Ca4j3pp9WCHxVUBAQpwkxLmKDZ0sZCX8852HmkFyxvizA1FM5y1QnwuEeRrdD1GUjvagNu 9lPUuB7NNKC1a0sRO9iuqUdpbs6CjHxLyScnPXbI/lh+qe2CWx6/N0tMASOY8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=toryanderson.com header.s=default header.b="krEIq+R/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.08 Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=toryanderson.com header.s=default header.b="krEIq+R/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: EE9E124D6A X-Spam-Score: -2.08 X-Migadu-Scanner: scn1.migadu.com X-TUID: nBfdV1JaO/xH I'm coming from very limited experience here -- gnus is the only MUA I've used -- but I'd be surprised if it's common practice to hijack a setting to set the MUA to something. As far as ripping the bandage off, I've followed that strategy many times in my professional life, but have come to dislike it; I'm in line with the Clojure paradigm to never break stuff. Sometimes that means namespacing, but in this case putting in the var with a default to preserve reverse compatibility is an easy thing, if a little kludgy. "Why was it ever doing this?" is a legitimate question, and it's no skin off my back if we simply chopped it out. But for a program as old and well-used as Notmuch, I would hate to break something that many users may not even realize they depended upon. Isn't it a good idea to make the fix available for those who want it, but non-breaking for those who have no idea? I suppose the docstring could be improved, and some options provided for those who don't know their MUAs. Trouble with options is, I don't know them, either -- only the notmuch MUA and 'gnus-user-agent. I'm not sure about others like mutt or muse or wanderlust or anything else. I'm not even sure if all of those have MUAs... - Tory Tomi Ollila writes: > On Sat, May 22 2021, David Bremner wrote: > >> webdev@toryanderson.com (Tory S. Anderson) writes: >> >>> >>> +(defcustom notmuch-mail-user-agent 'notmuch-user-agent >>> + "The mail user-agent to use when creating mail after using Notmuch. For historical purposes, the default is 'notmuch-user-agent" >>> + :group 'notmuch) >>> ;;; Mime Utilities >>> >>> (defun notmuch-foreach-mime-part (function mm-handle) >>> @@ -1162,7 +1165,7 @@ Point should be at the beginning of the line." >>> >>> ;;; _ >>> >>> -(setq mail-user-agent 'notmuch-user-agent) >>> +(setq mail-user-agent notmuch-mail-user-agent) >> >> OK, I appreciate idea of a smooth upgrade for existing notmuch users. I >> wonder though if other emacs MUAs do this? I did not see e.g. a >> gnus-mail-user-agent variable. I'm probably biased because I never use >> compose-mail to send mail, but I'm wondering if we're better off to just >> rip the bandage off and let users who want to use notmuch via generic >> emacs mail sending commands configure that. > > I am for 'ripping the bandage off' and not configure mail-user-agent > outside of notmuch use (and just require 'notmuch would not set anything...) > > Could we have some 'compose-mail' variant (different name, of course; > I had one in mind but then came off-by one problem... >;) which > configures mail-user-agent just for that use (or something). > > Tomi