From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kA+PMIrI+GJ2bwEAbAwnHQ (envelope-from ) for ; Sun, 14 Aug 2022 12:03:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QBaXMIrI+GINTAAA9RJhRA (envelope-from ) for ; Sun, 14 Aug 2022 12:03:54 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43BDA11B17 for ; Sun, 14 Aug 2022 12:03:54 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B8CC35E016; Sun, 14 Aug 2022 10:03:51 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 7B0315DC06 for ; Sun, 14 Aug 2022 10:03:48 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5B1845FBC0; Sun, 14 Aug 2022 06:03:47 -0400 (EDT) Received: (nullmailer pid 299829 invoked by uid 1000); Sun, 14 Aug 2022 10:03:46 -0000 Resent-To: notmuch@notmuchmail.org Resent-From: David Bremner Resent-Date: Sun, 14 Aug 2022 07:03:46 -0300 Resent-Message-ID: <87wnbbi1kt.fsf@tethera.net> From: David Bremner To: Mohsin Kaleem Subject: Re: [PATCH 8/9] review: Rename variables to better express intention In-Reply-To: <20220807145733.129867-8-mohkale@kisara.moe> References: <87v8re66mg.fsf@tethera.net> <20220807145733.129867-1-mohkale@kisara.moe> <20220807145733.129867-8-mohkale@kisara.moe> Date: Fri, 12 Aug 2022 07:55:21 -0300 Message-ID: <87ilmxg292.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: SSRMIUR2TEQSWUZY3XKS7QWCBRDOOYQM X-Message-ID-Hash: SSRMIUR2TEQSWUZY3XKS7QWCBRDOOYQM X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660471434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-owner:list-unsubscribe: list-subscribe:list-post; bh=P0oI8u6PD5/9suJ2AhteFstnSIMi9cOVIo+S8BLcmYE=; b=SNiuNJQuc6JzLdFQvqZLji7fXcx++vAho6ssvEYmLLSPjoFXiQtGpGDyTq3p7ub3U4o/kF 8AQFvFfQrqx40uXeV20/LDuRkkpQfYEzYS+8eCA99XydtVnXDExZmWeLzziIKO9JmELxdG gJR99J/jI5YrYKY+ackC+bYh8Ooq83YntVGCY4QGvW19omCMzmNCMBWBT0dgG63IzvZPNK X5p3Y3SM8PRmvpEaGmzBGT+J+guEtGXx4pE1ZZCBxdEl9UwAN0lmjYCq5BvafQzBAe1UHZ GUVml/tirCPiNwPI9Yt4gFchK2AnpDxcXXafNkjIGkLATEOHgSW3gQfSTIet/A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660471434; a=rsa-sha256; cv=none; b=EW/sMj4lh5/ccU16zjI0dUR0sVUKuZ4qELuq5oWRHroGElyRJ7X7E7Ii/VypiKTXK8Gm+m FseMBY39X7I4TmBVAwSGHyj7TU6LMQaYattChVgUIHzzwyoIk73BB/nyDE28mpbqxOG9c0 aiQI7Bs9SkJ827tRGtw6rpiBaPoefjzQiDeaTEGIWQNPi3U+RbYJV9v6ustGl98wK9i827 lRUlD430JypS/fbpJcLAXhj0W9gWuzzre/1RjQfmLPYSiwzKp1h+Mk18vaLhDyWW6HpG5n /MVl9K4o012WAWoJ52qNk/9houUp7EL+nO4LUUTvOdeJEstTPoe5a2OduBN6UA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 43BDA11B17 X-Spam-Score: -1.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: WpR58/oPGM7M Mohsin Kaleem writes: > --- > emacs/notmuch-hello.el | 18 +++++++++--------- > emacs/notmuch-jump.el | 2 +- > emacs/notmuch-lib.el | 4 ++-- > emacs/notmuch-tree.el | 24 ++++++++++++------------ > emacs/notmuch.el | 29 +++++++++++++++-------------- > 5 files changed, 39 insertions(+), 38 deletions(-) Please apply these fixes to the previous commits in the series, rather than sending an extra omnibus commit. magit is actually pretty good at that (c F).