From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wD92An8++GOinwAAbAwnHQ (envelope-from ) for ; Fri, 24 Feb 2023 05:35:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qPZtAn8++GOYRwAA9RJhRA (envelope-from ) for ; Fri, 24 Feb 2023 05:35:11 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B47D728FD4 for ; Fri, 24 Feb 2023 05:35:09 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 078EB5F71C; Fri, 24 Feb 2023 04:35:07 +0000 (UTC) X-Greylist: delayed 482 seconds by postgrey-1.36 at yantan; Fri, 24 Feb 2023 04:35:03 UTC Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mail.notmuchmail.org (Postfix) with ESMTPS id 17DE05F421 for ; Fri, 24 Feb 2023 04:35:03 +0000 (UTC) Received: from graphene.canonical.com (unknown [180.150.112.230]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id B93C541CFC for ; Fri, 24 Feb 2023 04:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1677212820; bh=487R4+n+uhy8o0nawvYkOhFoN1VdekykYWqiPORZnE0=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=cP+TQy/GiaG88Yn8zNTqOeYUwWvRn77fMISWEEUeM+gj1IatesJO5PiGlgzIz8St8 BXHXjPKnGAc2Jk6dVrT+O88AsCaVUbdLhHC189SsMM9lPu61auqj1fxojTY/SO73dt CCsPJ7A1MjHEPO+F4JwYGqTMT35G4CG7gtRgCnlvadsNfkk4ySfE6+bEf+UDUr4aQR DG+sSLtqvTr3ep0DuvGTO4to4Dc8cobETAJO5QyckF1gJAIhIObJ1qLJuRRG52G84k TgGDjAXrQQ0DN/jLRtFy+W8VQrk4pCKx0AA5bNsZM5IK+txFpqW5XhDx9tmCLLB0rD gEXei1zGAYJdQ== From: Alex Murray To: notmuch@notmuchmail.org Subject: notmuch-emacs inline image display broken in emacs-29 Date: Fri, 24 Feb 2023 14:56:54 +1030 Message-ID: <87ilfrg035.fsf@graphene.mail-host-address-is-not-set> MIME-Version: 1.0 Message-ID-Hash: B32KJ4K66ORJJSKSZEB3LYLIJGHU34ZU X-Message-ID-Hash: B32KJ4K66ORJJSKSZEB3LYLIJGHU34ZU X-MailFrom: alex.murray@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677213310; a=rsa-sha256; cv=none; b=uqhSurfBR8WzyF5gJyBhMHY9ml55XvON+gyXe+6R0Tr0iyRaIKCCJT2Qu024CW8PIgUgOe TIdgZc+2mVohLS7RbMlKelgYKIMmGDidCtQiGIrTKKSFho5CULu0DgOvVxS44nv692Bpbg TDU4fyrDaGn0wtNN9TtByT78i1uQsKFPlvVkA/Xon4cVU9I7Y6+LLwbe5VJQEn4yCTHX/R 9k7QUiG26G8frN1JxTEDJI881kIX/Ev90J22Yj9dwFVBQWHWxNGmFNpdU7Ng8Juhcd50oB 53IRH6+2y8byPY8c44YrdIAz8llko9lYkK6lmEZjpMWqWJHadkgEQamuOtIoIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=canonical.com header.s=20210705 header.b="cP+TQy/G"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677213310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=p4wKFOrqevvUEtCRyIC8QOqWnwVhFi6B9Xn4cOXbwyU=; b=F58tSZO8S4q90nOtfbZd39+liCp+RLENmEYX7cyQlLVTPJKKwY+eU0q3wGqeeJ8Rgca1Lk NWjdSG4nSPTBzDWl/k9pfpXZ71U9IEp+zf3yr0cit1Da6rjwR+P+DMtqH5o9lU6RO9bny4 06ZiyhpAeprbnAeSklgj4oy7cQDF9dtENxvvJAqpeOVbA3jXaJE3JeXu5u/DstHYXPT2Dq H3WthqUEyZ2tWYrQXYuqmWrueg5eIExzP69byuF/urxxDBDrVf5NRIOUnHv4yBmE6X/bb8 1s79KCE6OfhPkGNRyszFPzA2Bg9FwCXOzrPV1WzC41f+Kgt5805UZSah/VjolQ== X-Migadu-Spam-Score: -0.75 X-Spam-Score: -0.75 X-Migadu-Queue-Id: B47D728FD4 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=canonical.com header.s=20210705 header.b="cP+TQy/G"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-TUID: BQVHDxDnde9f Hi folks, I have noticed that inline image display doesn't work anymore in emacs-29 / git master and have tracked it down to a change to the way mm-inline-image inserts an image into the buffer. In https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d2186160a9e978960c0f96bc3b4fc65b5affc170 mm-inline-image was changed to use insert-image instead of put-image. This inserts the image into the buffer using a single space as the string contents with a display property set as the image contents so that the single space is not shown itself but instead the image is shown in its place. I had thought the culprit then was the use of notmuch-wash-elide-blank-lines within the default value of notmuch-show-insert-text/plain-hook - assuming that since the line containing the image is now just a single space, it then gets deleted from the buffer and the image is never shown. However, even after setting notmuch-show-insert-text/plain-hook to nil, images are still not shown inline by notmuch. However, if I locally redefine mm-inline-image to use say a period "." as the string argument to insert-image then the image appears as expected. Any thoughts on what may be happening here and how best to resolve this? Thanks, Alex