From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uDLMEayLz2QmewAASxT56A (envelope-from ) for ; Sun, 06 Aug 2023 14:01:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IETpEayLz2T/ogAA9RJhRA (envelope-from ) for ; Sun, 06 Aug 2023 14:01:48 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 20A3641E34 for ; Sun, 6 Aug 2023 14:01:48 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; none Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 70C395E00E; Sun, 6 Aug 2023 12:01:45 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id E70BC5DC0A for ; Sun, 6 Aug 2023 12:01:43 +0000 (UTC) Received: from tethera.net (fctnnbsc51w-159-2-210-253.dhcp-dynamic.fibreop.nb.bellaliant.net [159.2.210.253]) by phubs.tethera.net (Postfix) with ESMTPS id 3ABF1180172; Sun, 6 Aug 2023 09:01:42 -0300 (ADT) Received: (nullmailer pid 338679 invoked by uid 1000); Sun, 06 Aug 2023 12:01:40 -0000 From: David Bremner To: Kevin Boulain , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: showcase thread-unsafe s-expression query parser In-Reply-To: <878rao32r0.fsf@boula.in> References: <20230403203146.39749-1-kevin@boula.in> <87ilabg4u1.fsf@tethera.net> <878rao32r0.fsf@boula.in> Date: Sun, 06 Aug 2023 09:01:40 -0300 Message-ID: <87il9sbcrf.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: MEFDIF7VCAU5Z5RETHNNEJ5OZFM7C3PY X-Message-ID-Hash: MEFDIF7VCAU5Z5RETHNNEJ5OZFM7C3PY X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Queue-Id: 20A3641E34 X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -4.00 X-Migadu-Spam-Score: -4.00 X-TUID: mbXZx8LLy+Jx Kevin Boulain writes: > I would say it would be best to run all the tests with the different > instrumentations enabled (for the best coverage) but I don't know if > there's a CI. Or if out-of-tree compilation is supported, I guess the > ASan and TSan tests could recompile the library with the > instrumentation enabled... What do you think? The notmuch test-suite is optimized/intended for interactive use, so I don't know if the slowdown from a complete rebuild in several of the tests would be tolerable. Someone (TM) could check that. In principle out of tree builds should work, although they tend to bitrot, Running the whole test suite with instrumentation enabled is already an option (basically what you already did, but with more tests run), but then tests which depend on that instumentation should disable themselves if it is not present. I'm not sure if instrumentation can be reliably detected by introspection, or if there needs to be one or more configuration variables set with the configure script, and used by both build and test scripts. d