Re: [PATCH 1/2] test: showcase thread-unsafe s-expression query parser

[David Bremner <david@tethera.net>]

Kevin Boulain <kevin@boula.in> writes:

> I would say it would be best to run all the tests with the different
> instrumentations enabled (for the best coverage) but I don't know if
> there's a CI. Or if out-of-tree compilation is supported, I guess the
> ASan and TSan tests could recompile the library with the
> instrumentation enabled... What do you think?

The notmuch test-suite is optimized/intended for interactive use, so I
don't know if the slowdown from a complete rebuild in several of the
tests would be tolerable. Someone (TM) could check that. In principle
out of tree builds should work, although they tend to bitrot,

Running the whole test suite with instrumentation enabled is already an
option (basically what you already did, but with more tests run), but
then tests which depend on that instumentation should disable themselves
if it is not present. I'm not sure if instrumentation can be reliably
detected by introspection, or if there needs to be one or more
configuration variables set with the configure script, and used by both
build and test scripts.

d