Re: [PATCH v2 1/2] test: showcase thread-unsafe s-expression query parser

[David Bremner <david@tethera.net>]

Kevin Boulain <kevin@boula.in> writes:

> The test fails reliably when Notmuch is compiled as such:
>   ./configure
>   make CFLAGS=-fsanitize=thread LDFLAGS=-fsanitize=thread
> It's still unclear how the test suite could be run with the correct
> compilation flags.

At the moment I can think of 3 options:

1) have the test file check if the library is built with tsan, and to skip
if not. Something like "nm lib/libnotmuch.a| grep -q __tsan_init" seems
to do the trick here, although I don't know how portable it is.

2) Provide a "--with-tsan" option to set CFLAGS/LDFLAGS and also
   some variable that the tests can check

3) Do (2) by default if TSAN is detected, and provide --without-tsan to
disable it. This is only possible if the ruby bindings build is fixed to
ignore/work-with TSAN; currently it pretty much explodes.

All three options would need some thought as to how to support (if at
all) testing installed notmuch (new in 0.38, used by some CI systems).