From: David Bremner <david@tethera.net>
To: Kevin Boulain <kevin@boula.in>, notmuch@notmuchmail.org
Cc: Kevin Boulain <kevin@boula.in>
Subject: Re: [PATCH v2 1/2] test: showcase thread-unsafe s-expression query parser
Date: Tue, 19 Sep 2023 07:30:18 -0300 [thread overview]
Message-ID: <87il86foat.fsf@tethera.net> (raw)
In-Reply-To: <20230827123103.22744-1-kevin@boula.in>
Kevin Boulain <kevin@boula.in> writes:
> The test fails reliably when Notmuch is compiled as such:
> ./configure
> make CFLAGS=-fsanitize=thread LDFLAGS=-fsanitize=thread
> It's still unclear how the test suite could be run with the correct
> compilation flags.
At the moment I can think of 3 options:
1) have the test file check if the library is built with tsan, and to skip
if not. Something like "nm lib/libnotmuch.a| grep -q __tsan_init" seems
to do the trick here, although I don't know how portable it is.
2) Provide a "--with-tsan" option to set CFLAGS/LDFLAGS and also
some variable that the tests can check
3) Do (2) by default if TSAN is detected, and provide --without-tsan to
disable it. This is only possible if the ruby bindings build is fixed to
ignore/work-with TSAN; currently it pretty much explodes.
All three options would need some thought as to how to support (if at
all) testing installed notmuch (new in 0.38, used by some CI systems).
next prev parent reply other threads:[~2023-09-19 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:31 [PATCH 1/2] test: showcase thread-unsafe s-expression query parser Kevin Boulain
2023-04-03 20:31 ` [PATCH 2/2] lib: thread-safe " Kevin Boulain
2023-07-22 19:06 ` David Bremner
2023-08-27 12:31 ` [PATCH v2 1/2] test: showcase thread-unsafe " Kevin Boulain
2023-09-19 10:30 ` David Bremner [this message]
2023-08-27 12:31 ` [PATCH v2 2/2] lib: thread-safe " Kevin Boulain
2024-07-25 10:23 ` David Bremner
2023-08-27 12:33 ` [PATCH " Kevin Boulain
2023-07-22 18:48 ` [PATCH 1/2] test: showcase thread-unsafe " David Bremner
2023-07-23 13:23 ` Michael J Gruber
2023-07-23 14:03 ` David Bremner
2023-08-06 10:05 ` Kevin Boulain
2023-08-06 12:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il86foat.fsf@tethera.net \
--to=david@tethera.net \
--cc=kevin@boula.in \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).