Re: [PATCH] remove message archiving from show-advance-and-archive

[Jameson Rollins <jrollins@finestructure.net>]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

On Wed, 09 Jun 2010 16:36:53 +0100, David Edmondson <dme@dme.org> wrote:
> They are clearly different. If I read a thread with 'space' the 'unread'
> tag is removed from the messages as I pass them by. I can then 'q' from
> the thread and the messages are not archived ('inbox' is not removed),
> but they are no longer 'unread'.

But it's not necessarily clear that you've reached the end of a thread,
which means it's somewhat indeterministic if the "inbox" tag is removed
or not.  If users have to explicitly remove all tags other than
"unread", then this gets rid of this problem all together.

> Maybe you could submit a patch which allows a user to choose the
> behaviour with a customisation variable? (Though I'd expect the value of
> that variable to preserve backward compatible behaviour until Carl says
> otherwise.)

I actually submitted this patch because there was noise on #notmuch
about people (including from cworth) not liking the default behavior
where the "inbox" tag is removed by the advance function.

I would like to push it back the other way.  Having specific tags
modified by specific commands is something particular to individual
users.  If a user wants to do something special, they can make their own
function to do that.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]