From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BDB3C431FD0 for ; Thu, 23 Jun 2011 15:22:58 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6kQ9Oq5cNocl for ; Thu, 23 Jun 2011 15:22:58 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 229F4431FB6 for ; Thu, 23 Jun 2011 15:22:58 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 9EF4629A505; Thu, 23 Jun 2011 15:22:56 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 8CA0A254157; Thu, 23 Jun 2011 15:22:56 -0700 (PDT) From: Carl Worth To: Dmitry Kurochkin , Notmuch Mail Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. In-Reply-To: <87ipsmpswj.fsf@gmail.com> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> <1306619520-25730-9-git-send-email-jrollins@finestructure.net> <1306619520-25730-10-git-send-email-jrollins@finestructure.net> <1306619520-25730-11-git-send-email-jrollins@finestructure.net> <1306619520-25730-12-git-send-email-jrollins@finestructure.net> <1306619520-25730-13-git-send-email-jrollins@finestructure.net> <1306619520-25730-14-git-send-email-jrollins@finestructure.net> <1306619520-25730-15-git-send-email-jrollins@finestructure.net> <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com> <87oc2ellzn.fsf@yoom.home.cworth.org> <87ipsmpswj.fsf@gmail.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Thu, 23 Jun 2011 15:22:46 -0700 Message-ID: <87hb7gdw7d.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 22:22:58 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 04 Jun 2011 00:22:04 +0400, Dmitry Kurochkin wrote: > On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth wrote: > > > I do not think we need a test for this fix. What we need are tests f= or > > > FCC functionality when notmuch-fcc-dirs is a list. > >=20 > > Yes! I've written these now. And they do test this fix. What they show is that a legitimate setting (of notmuch-fcc-dirs as a list) was resulting in an error rather than working. That's a nasty little bug, (and poor coverage from our test suite before. > Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when > `notmuch-fcc-dirs' is set to a list. The error was in the > `notmuch-fcc-dirs' format check which was changed in an incompatible > way from 0.4 to 0.5. Thanks for the fixed wording. I've now pushed out the fix (along with the tests). With all the talk of "old style" vs. "new style" I was thinking that the bug only affected people with the old-style FCC setting. The bug is much worse than that, (preventing people from using the new list-based style). Anyway, thanks for the patch, Dmitry. And thanks for pushing me to take another look. David, I suggest including this fix (and its test) in the release branch. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4DvLYACgkQ6JDdNq8qSWiGZgCfbUBGxnMUytax1MpM1QG8H/2w t7sAn3S40trkxVf1Uh3Y0u0Mr5Mj4MJg =pHzP -----END PGP SIGNATURE----- --=-=-=--