From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 45057429E25 for ; Sat, 1 Oct 2011 18:46:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.7 X-Spam-Level: * X-Spam-Status: No, score=1.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k9r2s5SVWoqA for ; Sat, 1 Oct 2011 18:45:59 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 856B8431FB6 for ; Sat, 1 Oct 2011 18:45:59 -0700 (PDT) Received: by bkbzt12 with SMTP id zt12so4208665bkb.26 for ; Sat, 01 Oct 2011 18:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=wjtwxrJ2Fs4ixCzUT/uLITipS/GAvscEvO631iM9FPM=; b=CybBKGduuWXOnPH41kCLpXTHuOONF6jBvY+VBp6htaCEBLHr9JXK/BBITvvIg7Vgzh ev5VprTMjLwj74/mhgrY4WwbN7M4mHLfQsevVk8Zd4xqISo8v+EhtHl06zHa+UvzUxhP 5xlS8f4arYlUsE+9kp7wCx9euWmD1vcuMjkXE= Received: by 10.204.130.130 with SMTP id t2mr2497873bks.223.1317519956699; Sat, 01 Oct 2011 18:45:56 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id z9sm8940388bkn.7.2011.10.01.18.45.54 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Oct 2011 18:45:55 -0700 (PDT) From: Dmitry Kurochkin To: David Bremner Subject: Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part In-Reply-To: <87d3ehylon.fsf@zancas.localnet> References: <1309744743-8556-1-git-send-email-dmitry.kurochkin@gmail.com> <1309744743-8556-3-git-send-email-dmitry.kurochkin@gmail.com> <87zkhrlg8z.fsf@zancas.localnet> <874nzz2p3f.fsf@gmail.com> <87d3ehylon.fsf@zancas.localnet> User-Agent: Notmuch/0.8-50-gd528fd9 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 02 Oct 2011 05:45:53 +0400 Message-ID: <87hb3s414e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2011 01:46:00 -0000 Hi David. On Sat, 01 Oct 2011 08:51:20 -0300, David Bremner wrote: > On Mon, 26 Sep 2011 21:25:08 +0400, Dmitry Kurochkin wrote: > > Most likely the test passes because emacs is run in server mode and > > visibility stuff works differently. I sent a patch series [1] to run > > emacs in screen exactly for this reason. Please consider pushing it. > > Then the test should fail as expected. > > > [1] id:"1309496122-4965-1-git-send-email-dmitry.kurochkin@gmail.com" > > [2] id:"874o2germq.fsf@gmail.com" > I was wrong about it. I am moving to a new system. And I see the test pass on one system and fail on another. So it is not related to running emacs tests inside screen. At the moment, I have no idea why it behaves differently on the two systems. Both are Debian unstable (one is current another 2 weeks old). Could it be some extra emacs packages installed? I know notmuch disables system and user init files, but perhaps it is not enough? > I'd like to hear more feedback from people on the list about using > screen in the tests. Is this a portability issue for non-linux users? > Nevertheless, I believe running emacs tests inside screen is a requirement for doing complex UI tests. For example, `window-end' function behaves differently when there is no emacs frame. Of course, it does not have to be screen, we may use any other similar tool (e.g. tmux, dtach). We may even use a dummy X server. But screen seems to be the best option. I see no problem with not running emacs tests on systems which do not have screen. After all, emacs is a UI. Core tests would run fine as before. BTW there were patches to support tmux (or maybe it was dtach). IIRC the consensus was that supporting it does not worth complicating test lib. I think this can be reconsidered if it turns out that many users do not have screen, but do have tmux. But you never know if the patches are not applied. They have been around for several months, I doubt you would suddenly get feedback now. Regards, Dmitry > d