From: David Bremner <david@tethera.net>
To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org
Subject: Re: Patch review/application process
Date: Tue, 01 Nov 2011 11:28:45 -0300 [thread overview]
Message-ID: <87hb2n7w82.fsf@zancas.localnet> (raw)
In-Reply-To: <878vo8kdl2.fsf@gilead.invalid>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Tue, 25 Oct 2011 22:42:33 +0200, Daniel Schoepe <daniel@schoepe.org> wrote:
>. There is also a number of patches that have been reviewed by
> long-term contributors, but are then seemingly forgotten (I can find
> some concrete examples of this, if this claim is in doubt).
<pet-project-promotion>
Maybe you can tag those patches as "notmuch::reviewed" using nmbug? [1]
My idea is that
notmuch search tag:notmuch::patch and tag:notmuch::reviewed
should give a kind of consensus set of "ready to go" patch sets. Don't
worry about if I or someone else disagrees with your assessment, we can
always untag it, and leave a comment in the commit log. [2]
</pet-project-promotion>
There are also plenty of patches that are not reviewed at all. I'm not
defending the state of patch integration, but I think we could use some
more reviews as well.
d
[1]: http://notmuchmail.org/nmbug/
[2]: nmbug log $id could be defined as something like "cd $HOME/.nmbug && git log -- tags/$(echo $id | sha1sum -)"
[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]
next prev parent reply other threads:[~2011-11-01 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:42 Patch review/application process Daniel Schoepe
2011-10-25 23:16 ` David Bremner
2011-10-26 18:29 ` Jani Nikula
2011-10-26 18:55 ` Daniel Schoepe
2011-11-01 14:28 ` David Bremner [this message]
2011-11-01 15:55 ` Jameson Graef Rollins
2011-11-01 19:55 ` David Bremner
2011-11-01 21:27 ` Jameson Graef Rollins
2011-11-01 23:22 ` David Bremner
2011-11-01 23:43 ` Jameson Graef Rollins
2011-11-02 15:49 ` Philip Hands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb2n7w82.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=daniel@schoepe.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).