Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jameson Graef Rollins <jrollins@finestructure.net>]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula <jani@nikula.org> wrote:
> The code's there, and talk is cheap... but I'd rather like to see a
> solution that would make it easy for users to add arbitrary tagging
> operations to key bindings, instead of a fixed binding for "deleted".

It's already easy for users to add arbitrary key bindings.  It's emacs,
and the whole point of which is that it's infinitely extensible [0]:

(define-key notmuch-show-mode-map "d"
  (lambda ()
    "Delete current message and advance to next message."
    (interactive)
    (notmuch-show-add-tag "delete")
    (notmuch-show-next-open-message-or-pop)))

There really can't be an "easier" solution to add a key binding other
than just adding the above to your .emacs, and I really don't think it
would be worth it to try to make one.

The fact that it's already so easy to customize the key bindings is why
I've been reluctant (or even against) getting into protracted
discussions about what the default key bindings should be.  Everyone is
going to want a different behavior, and since it's easy enough to
customize, just let users define what they want.

> I wouldn't use it either, and I don't use "deleted" tag in the first
> place. And even if I used it, I'd still like to keep the distinction
> between "deleted after reading" and "deleted unread", which this patch
> loses by removing the "unread" tag.

Beyond what I just said about letting everyone customize things
themselves, I agree that I don't personally want other tags added or
removed when I "delete" a message.  The key binding above is actually
the one I use.

jamie.

[0] http://notmuchmail.org/emacstips/#index6h2

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]