Re: [PATCH] rewriting notmuch-search for structured output to make other output formats easier

[Jameson Graef Rollins <jrollins@finestructure.net>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On Sun, 22 Jan 2012 00:21:37 +0100, "Peter Feigl" <craven@gmx.net> wrote:
> What kind of documentation should I include?

Update the man page to describe the new format and command line options.

> The test suite should work fine, *if* it compares EXPECTED and OUTPUT
> not character-by-character, but rather by pretty-printing both the
> expected and the actual outputs by some JSON pretty-printer (like python
> -mjson.tool). I can of course provide additional test-cases for
> --format=sexp.

I was referring specifically to new tests for the new output format.
The test suite changes should include only additions, since as you point
out, the internal restructuring shouldn't affect any existing tests.

> How should I proceed on this? Re-submit the patch with the sexp-support
> removed and only JSON updated?

I think you should primarily work on addressing Austin's issues
regarding the output formatters first, being careful to try to make more
small atomic patches.  Then once that's done make a new series of
patches, depending on the new formatter patches, that adds the new
output format.

As Austin points out, more smaller patches that are narrowly focused are
much easier to review, even if there ends up being more changes in the
end.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]