unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact
Date: Thu, 23 Aug 2012 05:56:57 +0000	[thread overview]
Message-ID: <87haruxiae.fsf@kaki.tech.prive.nic.fr> (raw)
In-Reply-To: <m2txvv794d.fsf@guru.guru-group.fi> (Tomi Ollila's message of "Wed, 22 Aug 2012 09:07:14 +0300")

Tomi Ollila :

> On Tue, Aug 21 2012, Ben Gamari wrote:
>
>> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the
>> public API.
>
> Presuming that those variables are always numeric the comparison could be:
>
> if [ ${xapian_major_version} -gt 1 ] || 
>    [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] || 
>    [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \
>      ${xapian_subminor_version} -ge 6 ]; then
>
> (I could not figure out anything shorter and/or cleaner)

Try:

    case "${xapian_version}" in
         0.*|1.[01].*|1.2.[0-5]) ;;
         *) ... ;;
    esac

Kim Minh.

  reply	other threads:[~2012-08-23  5:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 15:31 [PATCH RFC?] Compactification support Ben Gamari
2012-08-20 15:31 ` [PATCH 1/3] Add notmuch_database_close_compact Ben Gamari
2012-08-21  7:35   ` Tomi Ollila
2012-08-21 14:49     ` Ben Gamari
2012-08-22  6:07       ` Tomi Ollila
2012-08-23  5:56         ` Kim Minh Kaplan [this message]
2012-08-23  6:26           ` Tomi Ollila
2012-08-20 15:31 ` [PATCH 2/3] Produce status messages during compacting Ben Gamari
2012-08-20 15:31 ` [PATCH 3/3] Add notmuch compact command Ben Gamari
2012-08-21  8:07 ` [PATCH RFC?] Compactification support Jani Nikula
2012-08-21 14:48   ` Ben Gamari
2012-08-21 15:25     ` Tomi Ollila
  -- strict thread matches above, loose matches on Subject: below --
2012-10-17 15:28 [PATCH] notmuch compact support Ben Gamari
2012-10-17 15:28 ` [PATCH 1/3] Add notmuch_database_close_compact Ben Gamari
2012-10-17 18:56   ` Jani Nikula
2012-10-18  6:44   ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haruxiae.fsf@kaki.tech.prive.nic.fr \
    --to=kimminh.kaplan+nomuch@afnic.fr \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).