From: David Bremner <david@tethera.net>
To: Robert Mast <beheerder@tekenbeetziekten.nl>, notmuch@notmuchmail.org
Subject: Re: [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned CHAR
Date: Sat, 16 Feb 2013 07:37:37 -0400 [thread overview]
Message-ID: <87halc7am6.fsf@zancas.localnet> (raw)
In-Reply-To: <1360769577-4861-1-git-send-email-beheerder@tekenbeetziekten.nl>
Robert Mast <beheerder@tekenbeetziekten.nl> writes:
> Using char instead of int allows for simpler definitions of the
> DOCIDSET macros so the code is easier to understand and consistent with
> respect to memory-usage. Estimated reduction of memory-usage for
> bitmap about 8 times.
Pushed to master.
I did a bit of testing, and this yields about a 7% improvement in the
total memory allocated on the medium corpus (running
performance-tests/M00-new) and about a 3% speedup running the large
corpus. These are definitely improvements worth having, but I think I
won't push it to the bug fix release, but rather wait for the next
regular release.
d
prev parent reply other threads:[~2013-02-16 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 18:51 [PATCH] This patch is a little finger excercise for working with git. I found a piece of code that I didn't understand at first Robert Mast
2013-02-03 20:01 ` Austin Clements
2013-02-10 13:13 ` [PATCH] convert bitmap to unsigned char Robert Mast
2013-02-11 18:56 ` Carl Worth
2013-02-10 17:24 ` [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned CHAR Robert Mast
2013-02-13 15:11 ` Robert Mast
2013-02-13 15:15 ` [english 100%] " Robert Mast
2013-02-13 15:32 ` Robert Mast
2013-02-13 16:21 ` Carl Worth
2013-02-16 11:37 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87halc7am6.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=beheerder@tekenbeetziekten.nl \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).