unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>
Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings
Date: Tue, 04 Jun 2013 11:22:29 -0300	[thread overview]
Message-ID: <87haheq7kq.fsf@zancas.localnet> (raw)
In-Reply-To: <20130604133738.GL5999@mit.edu>

Austin Clements <amdragon@MIT.EDU> writes:
>
> Right.  I think we should both reference the variable and say what the
> default behavior is (there's no reason not to do both).  But isn't
> that what these docstrings used to do?

Looking at the old docstrings in notmuch-show.el, I agree they basically
implement Tomi's suggestion.  While I think copying default values of
variables into docstrings creates some minor maintainability traps
(since we then need to remember to look at all the places a variable is
referenced if we change the default value), I'm willing to revert the
patch if people think the tradeoff of better usability is worth it.

It is unfortunate emacs doesn't provide a way to expand the current
value of a variable in the help string, but there we are. It probably
wouldn't be as easy to understand as hand crafted text in any case.

d

  reply	other threads:[~2013-06-04 14:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02 14:04 [PATCH] emacs: remove hardcoded defaults values from docstrings david
2013-06-02 14:29 ` [PATCH] emacs: add `notmuch-archive-tags' cross references in docstrings david
2013-06-02 14:32 ` [PATCH] emacs: remove hardcoded defaults values from docstrings Tomi Ollila
2013-06-02 17:47 ` Mark Walters
2013-06-03  0:03   ` David Bremner
2013-06-04  4:01 ` Austin Clements
2013-06-04  6:30   ` Tomi Ollila
2013-06-04 11:37     ` David Bremner
2013-06-04 13:37       ` Austin Clements
2013-06-04 14:22         ` David Bremner [this message]
2013-06-05  6:05           ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haheq7kq.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).