[PATCH 1/1] test: unset 'xpg_echo' bash shell option

[PATCH 1/1] test: unset 'xpg_echo' bash shell option

[Tomi Ollila]

When 'xpg_echo' bash shell option is unset (usually the default)
echo builtin does not expand backslash-escape sequences by default
(i.e. '\n' is echoed as '\n' instead of newline). Not all bash
installations have this feature we depend on activated by default.

Note that the feature is bash (and GNU /bin/echo) specific. It is used
as it is convenient. If portability is needed (elsewhere) use printf(1)
(also often available as a shell builtin).
---
 test/test-lib.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index ffab1bb..d3a8c58 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -22,6 +22,9 @@ if [ ${BASH_VERSINFO[0]} -lt 4 ]; then
     exit 1
 fi
 
+# Make sure echo builtin does not expand backslash-escape sequences by default.
+shopt -u xpg_echo
+
 # if --tee was passed, write the output not only to the terminal, but
 # additionally to the file test-results/$BASENAME.out, too.
 case "$GIT_TEST_TEE_STARTED, $* " in
-- 
1.8.0

Re: [PATCH 1/1] test: unset 'xpg_echo' bash shell option

[Vladimir Marek]

Yes, that fixes the tests on Solaris which were broken by the 'echo'
performing differently. If my vote counts, put it in, please!

Thank you
-- 
	Vlad

> When 'xpg_echo' bash shell option is unset (usually the default)
> echo builtin does not expand backslash-escape sequences by default
> (i.e. '\n' is echoed as '\n' instead of newline). Not all bash
> installations have this feature we depend on activated by default.
> 
> Note that the feature is bash (and GNU /bin/echo) specific. It is used
> as it is convenient. If portability is needed (elsewhere) use printf(1)
> (also often available as a shell builtin).
> ---
>  test/test-lib.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index ffab1bb..d3a8c58 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -22,6 +22,9 @@ if [ ${BASH_VERSINFO[0]} -lt 4 ]; then
>      exit 1
>  fi
>  
> +# Make sure echo builtin does not expand backslash-escape sequences by default.
> +shopt -u xpg_echo
> +
>  # if --tee was passed, write the output not only to the terminal, but
>  # additionally to the file test-results/$BASENAME.out, too.
>  case "$GIT_TEST_TEE_STARTED, $* " in
> -- 
> 1.8.0
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] test: unset 'xpg_echo' bash shell option

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> When 'xpg_echo' bash shell option is unset (usually the default)
> echo builtin does not expand backslash-escape sequences by default
> (i.e. '\n' is echoed as '\n' instead of newline). Not all bash
> installations have this feature we depend on activated by default.

pushed,

d