From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Felipe Contreras <felipe.contreras@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: add workaround for systems without zlib.pc
Date: Fri, 13 Jun 2014 22:47:56 -0300 [thread overview]
Message-ID: <87ha3o5kj7.fsf@zancas.localnet> (raw)
In-Reply-To: <m2wqdrqay8.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
>> +static const char *template =
>> + "prefix=/usr\n"
>> + "exec_prefix=${prefix}\n"
>> + "libdir=${exec_prefix}/lib\n"
>> + "\n"
>> + "Name: zlib\n"
>> + "Description: zlib compression library\n"
>> + "Version: %s\n"
>> + "Libs: -lz\n";
>
> The above is bit different what zlib.pc files have in e.g. Fedora 20 and
> Ubuntu 14.04 machines: those have 'Requires: before Libs: (and Cflags:)'
> But probably that is unnecessary (and just some sugar coating...?).
>
it seems consistent with the 'foo' example at
http://people.freedesktop.org/~dbn/pkg-config-guide.html#writing
>
> To be consistent what we do elsewhere:
>
> PKG_CONFIG_PATH=${PKG_CONFIG_PATH:+$PKG_CONFIG_PATH:}compat &&
>
> i.e. don't add ':' in case $PKG_CONFIG_PATH is not defined or is empty string.
What Tomi writes here sounds correct to me. I guess empty PKG_CONFIG_PATH is
probably the most common case.
d
next prev parent reply other threads:[~2014-06-14 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 3:09 [PATCH] configure: add workaround for systems without zlib.pc Felipe Contreras
2014-05-12 4:39 ` David Bremner
2014-05-12 15:21 ` Tomi Ollila
2014-06-14 1:47 ` David Bremner [this message]
2014-06-22 9:58 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha3o5kj7.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).