unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches
Date: Mon, 04 Aug 2014 20:00:41 -0300	[thread overview]
Message-ID: <87ha1r6esm.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1405433166-2198-2-git-send-email-amdragon@mit.edu>

Austin Clements <amdragon@MIT.EDU> writes:

> This introduces notmuch-jump, which is like a user-friendly,
> user-configurable global prefix map for saved searches.  This provi

Unfortunately this patch doesn't apply anymore.

> @@ -18,7 +18,8 @@ emacs_sources := \
>  	$(dir)/notmuch-tag.el \
>  	$(dir)/coolj.el \
>  	$(dir)/notmuch-print.el \
> -	$(dir)/notmuch-version.el
> +	$(dir)/notmuch-version.el \
> +	$(dir)/notmuch-jump.el \

Why the extra \ ?

> +(defun notmuch-jump--plist-delete (plist property)
> +  (let* ((xplist (cons nil plist))
> +	 (pred xplist))
> +    (while (cdr pred)
> +      (when (eq (cadr pred) property)
> +	(setcdr pred (cdddr pred)))
> +      (setq pred (cddr pred)))
> +    (cdr xplist)))

Should this function maybe be somewhere more generic?

  reply	other threads:[~2014-08-04 23:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 16:02 [PATCH 0/2] emacs: Shortcut keys to saved searches Austin Clements
2014-07-14 16:02 ` [PATCH 1/2] emacs: Introduce notmuch-jump: shortcut " Austin Clements
2014-07-14 21:22   ` Mark Walters
2014-07-15  3:46     ` Austin Clements
2014-07-15  7:02       ` Mark Walters
2014-07-14 16:02 ` [PATCH 2/2] emacs: Expand default saved searches and add shortcut keys Austin Clements
2014-07-15 14:06 ` [PATCH v2 0/2] emacs: Shortcut keys to saved searches Austin Clements
2014-07-15 14:06   ` [PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut " Austin Clements
2014-08-04 23:00     ` David Bremner [this message]
2014-08-05  1:44       ` Austin Clements
2014-08-05  1:45         ` [PATCH v3 " Austin Clements
2014-08-05  1:45           ` [PATCH v3 2/2] emacs: Expand default saved searches and add shortcut keys Austin Clements
2014-08-05 11:20           ` [PATCH v3 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches David Bremner
2014-07-15 14:06   ` [PATCH v2 2/2] emacs: Expand default saved searches and add shortcut keys Austin Clements
2014-07-15 22:06     ` David Bremner
2014-07-15 20:18   ` [PATCH v2 0/2] emacs: Shortcut keys to saved searches Mark Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha1r6esm.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).