Re: [PATCH] cli: notmuch address option defaults update

[Michal Sojka <sojkam1@fel.cvut.cz>]

On Thu, Nov 06 2014, Tomi Ollila wrote:
> When no --output option were given, change default to display senders
> only. This is faster and provides useful-enough list of addresses.
>
> When only --count option is given, display senders (in contrary to not
> displaying anything).
>
> Document how --count affects to "sort order" a bit more accurately.
>
> Clean up some whitespace in the documentation.
>
> One test updated to have --output=count without sender nor recipient
> output option.
> ---
>
> Some quick updates to the notmuch address interface which I hope will
> be considered to be included in 0.19 release. As we are in feature freeze
> I hope this gets quick feedback, in any way you desire.
>
> Tomi
>
>  doc/man1/notmuch-address.rst | 34 ++++++++++++++++++----------------
>  notmuch-search.c             |  4 ++--
>  test/T095-address.sh         | 14 +++++++-------
>  3 files changed, 27 insertions(+), 25 deletions(-)
>
> diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst
> index 359616e0dc5f..034607c434d2 100644
> --- a/doc/man1/notmuch-address.rst
> +++ b/doc/man1/notmuch-address.rst
> @@ -32,28 +32,28 @@ Supported options for **address** include
>      ``--output=(sender|recipients|count)``
>  
>          Controls which information appears in the output. This option
> -	can be given multiple times to combine different outputs.
> -	Omitting this option is equivalent to
> -	--output=sender --output=recipients.
> +        can be given multiple times to combine different outputs.
> +        Omitting this option is equivalent to --output=sender.

The implementation does a bit more. What about:

    When neither --output=sender nor --output=recipients is given,
    --output=sender is implied.

Otherwise it LGTM.

Thanks,
-Michal