unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [Patch v4 5/5] test: add broken test for SMIME decryption with notmuch CLI
Date: Mon, 26 Jan 2015 23:59:40 +0100	[thread overview]
Message-ID: <87h9vdup0j.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1421568167-18683-6-git-send-email-david@tethera.net>

David Bremner <david@tethera.net> writes:

> The test JSON here is not correct, but the larger problem is thatit
> seems like no actual decryption is being done.

I played with this some more, and it seems like Jamie's code (and the
gmime sample code [1] expects the top level part to be
multipart/encrypted.  Message-mode on the other hand generates messages
with a single application/x-pkcs7-mime part.  According to my reading of
rfc5751 section 3.9, they're both wrong. 'application/pkcs7-mime' is
legit, as is, wait for it, "application/octet-stream" with a file suffix
of "p7m", "p7s", "p7c", or "p7z".  So I guess we have to check for
x-pkcs7-mime as well?  Apparently this has only been a known problem [2]
for 15 years or so.

[1]: https://github.com/GNOME/gmime/blob/master/tests/test-smime.c
[2]: http://www.imc.org/ietf-smime/mail-archive/msg00726.html

  reply	other threads:[~2015-01-26 23:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18  8:02 S/MIME patches, v4 David Bremner
2015-01-18  8:02 ` [Patch v4 1/5] test: initial tests for S/MIME and notmuch-emacs David Bremner
2015-01-18  8:02 ` [Patch v4 2/5] cli: S/MIME verification/decryption support David Bremner
2015-01-18 10:45   ` [PATCH 0/3] smime with some refactoring Jani Nikula
2015-01-18 10:45     ` [PATCH 1/3] crypto: refactor context creation to facilitate further work Jani Nikula
2015-01-18 17:07       ` David Bremner
2015-01-18 10:45     ` [PATCH 2/3] crypto: make crypto ctx initialization an array Jani Nikula
2015-01-18 17:10       ` David Bremner
2015-01-18 10:45     ` [PATCH 3/3] cli: crypto: S/MIME verification/decryption support Jani Nikula
2015-01-18 17:14       ` David Bremner
2015-03-02 17:56         ` Jameson Graef Rollins
2015-01-18  8:02 ` [Patch v4 3/5] test: add S/MIME signature verification test for notmuch CLI David Bremner
2015-01-18  8:02 ` [Patch v4 4/5] debian: Recommend gpgsm for S/MIME support David Bremner
2015-01-18  8:02 ` [Patch v4 5/5] test: add broken test for SMIME decryption with notmuch CLI David Bremner
2015-01-26 22:59   ` David Bremner [this message]
2015-01-28  7:36     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9vdup0j.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).