From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 40C4C6DE1413 for ; Sun, 28 Feb 2016 07:05:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.035 X-Spam-Level: X-Spam-Status: No, score=-0.035 tagged_above=-999 required=5 tests=[AWL=-0.024, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9OhEerRQdJ3x for ; Sun, 28 Feb 2016 07:05:39 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 5E42E6DE13ED for ; Sun, 28 Feb 2016 07:05:39 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1aa2vK-0008V3-BM; Sun, 28 Feb 2016 10:06:18 -0500 Received: (nullmailer pid 2683 invoked by uid 1000); Sun, 28 Feb 2016 15:05:37 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH v3 16/16] add "notmuch reindex" subcommand In-Reply-To: <1454272801-23623-17-git-send-email-dkg@fifthhorseman.net> References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net> <1454272801-23623-17-git-send-email-dkg@fifthhorseman.net> User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sun, 28 Feb 2016 11:05:37 -0400 Message-ID: <87h9gs50zi.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2016 15:05:41 -0000 Daniel Kahn Gillmor writes: > This new subcommand takes a set of search terms, and re-indexes the > list of matching messages using the supplied options. > > This can be used to index the cleartext of encrypted messages with > something like: > > notmuch reindex --try-decrypt \ > tag:encrypted and not tag:index-decrypted I haven't reviewed this patch yet. Before I do I'd like to discuss the issue of the apparent existing bug in thread handling that it exposes[1]. Assuming that analysis is correct (and I have no reason not to believe so), the bug is in existing notmuch code and not related to this change. On the other hand, currently users have to work a bit to expose this bug, while this command would be inherently buggy (through no fault of it's own) from introduction. With my release manager hat on, I'm not very happy with the hypothetical announcement "We have this new command, but it will break your threads". So what I'd like to understand is to what extent the reindex command, with the current notmuch codebase (i.e. no new ghost message code), is "suitable for release". One option would be to merge a version of most of the proposed changes (with some minor updates), and leave the re-index (and maybe python bindings changes) for a second series. [1]: id:871t8ko50r.fsf@alice.fifthhorseman.net