unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Sam Halliday <sam.halliday@gmail.com>, notmuch@notmuchmail.org
Subject: Re: use font-face instead of explicit colouring
Date: Sat, 05 Mar 2016 11:00:00 +0000	[thread overview]
Message-ID: <87h9glb367.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87k2lhmecn.fsf@gmail.com>


Hi

On Sat, 05 Mar 2016, Sam Halliday <sam.halliday@gmail.com> wrote:
> I should say that I am aware of the workaround, e.g.
>
>     (setq
>       notmuch-search-line-faces '(("unread" :weight bold)
>                                   ("flagged" :inherit 'font-lock-string-face)))
>
> but this must be applied per-user. If you removed this defcustom and had
> unread/flagged/other faces, then themes (such as darcula) would be able
> to provide sensible defaults out of the box.

I am not sure I see how this would work without cluttering up the
customize options significantly. The notmuch-search-line-faces allows
selecting the face based on any tag (so for example I use different
colours for emails tagged "work", and tagged "waiting"). We could have
additional notmuch-search-line-unread-face which could then be  used in
the above -- but now the user has two places to customize the same thing.

How do you see this working?

(We probably could make the default depend on light or dark theme to make
the default more usable.)

Best wishes

Mark

>
> Sam Halliday <sam.halliday@gmail.com> writes:
>
>> [ text/plain ]
>> Hi,
>>
>> I use a dark theme and many of the colour choices of notmuch collide
>> with my theme. However, notmuch is explicitly adding information such as
>> "blue foreground" instead of using faces that I can customise.
>>
>> Could you please consider using faces instead of explicit colours?
>>
>> [ text/plain ]
>>
>> -- 
>> Best regards,
>> Sam
>> [ signature.asc: application/pgp-signature ]
>
> -- 
> Best regards,
> Sam
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2016-03-05 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05  9:54 use font-face instead of explicit colouring Sam Halliday
2016-03-05 10:03 ` Sam Halliday
2016-03-05 11:00   ` Mark Walters [this message]
2016-03-05 11:09     ` Sam Halliday
2016-03-05 11:26       ` Mark Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9glb367.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    --cc=sam.halliday@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).