From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 652256DE0B64 for ; Fri, 9 Sep 2016 23:22:21 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.581 X-Spam-Level: X-Spam-Status: No, score=-0.581 tagged_above=-999 required=5 tests=[AWL=0.139, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oTrDkR16YtoS for ; Fri, 9 Sep 2016 23:22:19 -0700 (PDT) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by arlo.cworth.org (Postfix) with ESMTPS id 49A126DE0B2B for ; Fri, 9 Sep 2016 23:22:19 -0700 (PDT) Received: by mail-wm0-f46.google.com with SMTP id b187so62258598wme.1 for ; Fri, 09 Sep 2016 23:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=1LF28oYew7D0w2xc0ZjLhEmamla/0PBUCl47zt400SI=; b=w/izy16Hvpxa3cohPDQNjTwUxS+IxnFvxs5kLu2xQpk2yivJmd0KIgNndu0/MH27Z5 P9rhEopc6k8xk0C4nzmf6Jh1w9KVWZs8CFJihReMvwpw+VjRI5Rg4L739h3Ukit8cgH8 FY0QVU+CmUgyNflpr2VyU+qppWreFhdCTqevioyahZ8k0IQw4sbH0H3mVToZZGSaZuop R4xtaVIeSEGPFwOZcn3pJEyRsonT3JTAAx9SNecLYrklV0aAb0qyXS4Mbm929c3kknIT tERiLGro3WhErmxB8a+nfR8kB8SYg4UTiUrWt9ZOVSph5u35pJcXiFOJTWzez91V4heV Ov6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=1LF28oYew7D0w2xc0ZjLhEmamla/0PBUCl47zt400SI=; b=P44ymMy/BuCNtcpHrtH0hQ7YxMPDV9RmkM2Tl2Xbs904rcPHNgZRwG9axLDJvta6Qy PBHmdQqg03054pFgngyiC460asNeL53V8tLPs4bSST0jzoSsDc2T7Bhpm/YrYhuuAzcu 7WfdwwD+/CQH4zaskhmE7uyAnY3oY9kEdnW9UDRNL8SeDUQst128TMIuV6rS/bnfsGFf ptVLCPyEapIQDjhKkTlIHN8BCVw10psgKt8tD6bC5H3WPCI3LwX0lJLFkCwxXb2LfWGt aM5KOb/K8kBySRwOwHdAIVAWW8F3SB79L7T/Gui6dhv7nqe+biXH7l/T8C7ZPHjOd4/w kRiA== X-Gm-Message-State: AE9vXwPT+8FMs9tsgJ34M0/Uy35MZSegZYxeBy7tPjrYlaLaKIsv+K3D2Fi3/1fBB0ClRQ== X-Received: by 10.28.10.194 with SMTP id 185mr1461628wmk.53.1473488536197; Fri, 09 Sep 2016 23:22:16 -0700 (PDT) Received: from localhost (mobile-access-bcee6a-45.dhcp.inet.fi. [188.238.106.45]) by smtp.gmail.com with ESMTPSA id r9sm6767274wjp.15.2016.09.09.23.22.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Sep 2016 23:22:15 -0700 (PDT) From: Jani Nikula To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack In-Reply-To: <87mvjg1snt.fsf@zancas.localnet> References: <3760ff3cc6083d5f24c280a97121beccce8e0c5e.1471088022.git.jani@nikula.org> <87mvjg1snt.fsf@zancas.localnet> Date: Sat, 10 Sep 2016 09:20:33 +0300 Message-ID: <87h99owa1a.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 06:22:21 -0000 On Sat, 10 Sep 2016, David Bremner wrote: > Jani Nikula writes: > >> - if (mime_node_open (ctx, message, &(params->crypto), &root) == NOTMUCH_STATUS_SUCCESS) { >> - format_part_reply (root); >> - talloc_free (root); >> - } >> + g_object_unref (G_OBJECT (reply)); >> >> - notmuch_message_destroy (message); >> + if (mime_node_open (ctx, message, ¶ms->crypto, &root) == NOTMUCH_STATUS_SUCCESS) { >> + format_part_reply (root); >> + talloc_free (root); > > I'm not sure I should admit this, but I'd have to check a book to make > sure that ¶ms->crypto is the same as &(params->crypto) Nah, you wouldn't have to check a book. If it weren't the same, it wouldn't compile. :) BR, Jani.