From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 205A36DE0B14
 for <notmuch@notmuchmail.org>; Fri,  9 Sep 2016 18:38:37 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.007
X-Spam-Level: 
X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Zhxh6VfGck_y for <notmuch@notmuchmail.org>;
 Fri,  9 Sep 2016 18:38:36 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 417606DE0B00
 for <notmuch@notmuchmail.org>; Fri,  9 Sep 2016 18:38:36 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1biXFU-0002UO-8y; Fri, 09 Sep 2016 21:38:28 -0400
Received: (nullmailer pid 26691 invoked by uid 1000);
 Sat, 10 Sep 2016 01:38:30 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 04/14] cli/reply: unify reply format functions
In-Reply-To: <bcf94cd7a49879a9d168f7b8b0a9c77c41335237.1471088022.git.jani@nikula.org>
References: <cover.1471088022.git.jani@nikula.org>
 <bcf94cd7a49879a9d168f7b8b0a9c77c41335237.1471088022.git.jani@nikula.org>
User-Agent: Notmuch/0.22.2 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Fri, 09 Sep 2016 22:38:30 -0300
Message-ID: <87h99o1qll.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Sep 2016 01:38:37 -0000

Jani Nikula <jani@nikula.org> writes:

> Prepare for further future unification by making the code similar. The
> only functional change is that errors in mime_node_open() also break
> execution in default reply format.

>      GMimeMessage *reply;
> -    mime_node_t *root;
> +    mime_node_t *node;
> +
> +    if (mime_node_open (ctx, message, &params->crypto, &node))
> +	return 1;
>  
>      reply = create_reply_message (ctx, config, message, reply_all);
>      if (!reply)
>  	return 1;
>  
>      show_reply_headers (reply);
> +    format_part_reply (node);
>  
>      g_object_unref (G_OBJECT (reply));

I'm not sure if this matters in the long run, but a related change is
that the g_object_unref is skipped in case mime_node_open returns an
error.

d